From: Randy Dunlap <rdunlap@infradead.org>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: [PATCH -next] extcon: fix extcon-sm5502 build when CONFIG_I2C=m
Date: Wed, 13 Aug 2014 00:22:22 -0700 [thread overview]
Message-ID: <53EB122E.3050407@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors in extcon-sm5502.c by making EXTCON_SM5502 depend
on I2C since it selects REGMAP_I2C. The build errors happen when
CONFIG_I2C=m and CONFIG_EXTCON_SM5502=y. This Kconfig change causes
CONFIG_EXTCON_SM5502 to be =m when CONFIG_I2C=m.
drivers/built-in.o: In function `regmap_smbus_byte_reg_read':
regmap-i2c.c:(.text+0x5030a): undefined reference to `i2c_smbus_read_byte_data'
drivers/built-in.o: In function `regmap_smbus_byte_reg_write':
regmap-i2c.c:(.text+0x50338): undefined reference to `i2c_smbus_write_byte_data'
drivers/built-in.o: In function `regmap_smbus_word_reg_read':
regmap-i2c.c:(.text+0x50356): undefined reference to `i2c_smbus_read_word_data'
drivers/built-in.o: In function `regmap_smbus_word_reg_write':
regmap-i2c.c:(.text+0x50384): undefined reference to `i2c_smbus_write_word_data'
drivers/built-in.o: In function `regmap_i2c_read':
regmap-i2c.c:(.text+0x503cf): undefined reference to `i2c_transfer'
drivers/built-in.o: In function `regmap_i2c_gather_write':
regmap-i2c.c:(.text+0x50442): undefined reference to `i2c_transfer'
drivers/built-in.o: In function `regmap_i2c_write':
regmap-i2c.c:(.text+0x50474): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `sm5502_muic_i2c_init':
extcon-sm5502.c:(.init.text+0x6630): undefined reference to `i2c_register_driver'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/extcon/Kconfig | 1 +
1 file changed, 1 insertion(+)
Index: linux-next-20140813/drivers/extcon/Kconfig
===================================================================
--- linux-next-20140813.orig/drivers/extcon/Kconfig
+++ linux-next-20140813/drivers/extcon/Kconfig
@@ -72,6 +72,7 @@ config EXTCON_PALMAS
config EXTCON_SM5502
tristate "SM5502 EXTCON support"
+ depends on I2C
select IRQ_DOMAIN
select REGMAP_I2C
select REGMAP_IRQ
next reply other threads:[~2014-08-13 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 7:22 Randy Dunlap [this message]
2014-08-13 7:40 ` [PATCH -next] extcon: fix extcon-sm5502 build when CONFIG_I2C=m Chanwoo Choi
2014-08-15 23:36 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EB122E.3050407@infradead.org \
--to=rdunlap@infradead.org \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.