From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: Duplicated arch_gnttab_init breaks the arm64 kernel
 build
Date: Wed, 13 Aug 2014 10:31:56 +0100
Message-ID: <53EB308C.7020505@citrix.com>
References: <0B60D476-C0E4-4AE8-9FF9-C16F65352C33@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <0B60D476-C0E4-4AE8-9FF9-C16F65352C33@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Chen Baozi <baozich@gmail.com>, David Vrabel <david.vrabel@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Grall Julien <julien.grall@linaro.org>, Campbell Ian <ian.campbell@citrix.com>, List Developer Xen <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 13/08/14 03:04, Chen Baozi wrote:
> Hi David & Konrad, =

> =

> The current upstream kernel fails to build with Xen support because of du=
plicated
> arch_gnttab_init() definition:
> =

>   CC      arch/arm64/xen/../../arm/xen/grant-table.o
> arch/arm64/xen/../../arm/xen/grant-table.c:53:5: error: conflicting types=
 for =91arch_gnttab_init=92
>  int arch_gnttab_init(unsigned long nr_shared, unsigned long nr_status)
>      ^
> arch/arm64/xen/../../arm/xen/grant-table.c:48:5: note: previous definitio=
n of =91arch_gnttab_init=92 was here
>  int arch_gnttab_init(unsigned long nr_shared)
>      ^
> make[1]: *** [arch/arm64/xen/../../arm/xen/grant-table.o] Error 1
> make: *** [arch/arm64/xen] Error 2
> =

> I looked through the current upstream kernel tree. It looks like arch_gnt=
tab_init()
> is still be called in the older fashion (int arch_gnttab_init(unsigned lo=
ng nr_shared)).
> So I doubt if the b7dd0e3 at this stage of time?

I have just sent a pull request including a fix for this.

Thanks.

David