Re: [PATCH net-next 02/10] IB/mlx5: Add support for extended query device

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 8/13/2014 3:39 PM, Eli Cohen wrote:

> Add a new entry for query device extended which currently has identical
> functionality to query_device and publish support for it.

> Signed-off-by: Eli Cohen <eli@mellanox.com>
> ---
>   drivers/infiniband/hw/mlx5/main.c | 25 +++++++++++++++++++++++--
>   1 file changed, 23 insertions(+), 2 deletions(-)

> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index d8907b20522a..63fddeec90af 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
[...]
> @@ -775,6 +781,17 @@ static int mlx5_ib_dealloc_pd(struct ib_pd *pd)
>   	return 0;
>   }
>
> +static int mlx5_ib_query_device_ex(struct ib_device *device,
> +				   struct ib_device_attr *attr,
> +				   struct ib_udata *uhw)
> +{
> +	int err;
> +
> +	err = query_device(device, attr);
> +
> +	return err;
> +}

   Why not just:

	return query_device(device, attr);

WBR, Sergei