Re: Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

[Juergen Gross <jgross@suse.com>]

On 08/13/2014 09:02 AM, Juergen Gross wrote:
> On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote:
>> Hi Juergen & Co,
>>
>> Finally had a chance to review this code.  Comments are inline below..

>>> +static struct se_node_acl *
>>> +scsiback_alloc_fabric_acl(struct se_portal_group *se_tpg)
>>> +{
>>> +    struct scsiback_nacl *nacl;
>>> +
>>> +    nacl = kzalloc(sizeof(struct scsiback_nacl), GFP_KERNEL);
>>> +    if (!nacl) {
>>> +        pr_err("Unable to allocate struct scsiback_nacl\n");
>>> +        return NULL;
>>> +    }
>>> +
>>> +    return &nacl->se_node_acl;
>>> +}
>>> +
>>> +static void
>>> +scsiback_release_fabric_acl(struct se_portal_group *se_tpg,
>>> +                 struct se_node_acl *se_nacl)
>>> +{
>>> +    struct scsiback_nacl *nacl = container_of(se_nacl,
>>> +            struct scsiback_nacl, se_node_acl);
>>> +    kfree(nacl);
>>> +}
>>> +
>>> +static u32 scsiback_tpg_get_inst_index(struct se_portal_group *se_tpg)
>>> +{
>>> +    return 1;
>>> +}
>>> +
>>> +static struct se_node_acl *
>>> +scsiback_make_nodeacl(struct se_portal_group *se_tpg,
>>> +               struct config_group *group,
>>> +               const char *name)
>>> +{
>>> +    struct se_node_acl *se_nacl, *se_nacl_new;
>>> +    struct scsiback_nacl *nacl;
>>> +    u64 wwpn = 0;
>>> +    u32 nexus_depth;
>>> +
>>> +    se_nacl_new = scsiback_alloc_fabric_acl(se_tpg);
>>> +    if (!se_nacl_new)
>>> +        return ERR_PTR(-ENOMEM);
>>> +
>>> +    nexus_depth = 1;
>>> +    /*
>>> +     * se_nacl_new may be released by core_tpg_add_initiator_node_acl()
>>> +     * when converting a NodeACL from demo mode -> explict
>>> +     */
>>> +    se_nacl = core_tpg_add_initiator_node_acl(se_tpg, se_nacl_new,
>>> +                name, nexus_depth);
>>> +    if (IS_ERR(se_nacl)) {
>>> +        scsiback_release_fabric_acl(se_tpg, se_nacl_new);
>>> +        return se_nacl;
>>> +    }
>>> +    /*
>>> +     * Locate our struct scsiback_nacl and set the FC Nport WWPN
>>> +     */
>>> +    nacl = container_of(se_nacl, struct scsiback_nacl, se_node_acl);
>>> +    nacl->iport_wwpn = wwpn;
>>> +
>>> +    return se_nacl;
>>> +}
>>> +
>>> +static void scsiback_drop_nodeacl(struct se_node_acl *se_acl)
>>> +{
>>> +    struct scsiback_nacl *nacl = container_of(se_acl,
>>> +                struct scsiback_nacl, se_node_acl);
>>> +    core_tpg_del_initiator_node_acl(se_acl->se_tpg, se_acl, 1);
>>> +    kfree(nacl);
>>> +}
>>> +
>>
>> As mentioned above, the NodeACL use is unnecessary for this driver so
>> you can safely drop scsiback_make_node_acl() +
>> scsiback_alloc_fabric_acl() + scsiback_drop_nodeacl() +
>> scsiback_release_fabric_acl().
>
> Deleted.

target_fabric_tf_ops_check() complains about missing
tpg_alloc_fabric_acl and tpg_release_fabric_acl.


>>> +static void scsiback_set_default_node_attrs(struct se_node_acl *nacl)
>>> +{
>>> +}
>>> +
>>
>> Safe to drop this no-op too.
>
> Okay.

target_fabric_tf_ops_check() wants this to be set, too.


Juergen