From: Daniel Borkmann <dborkman@redhat.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: Alex Gartrell <agartrell@fb.com>,
horms@verge.net.au, lvs-devel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH ipvs] ipvs: Add selftests for ipvs
Date: Thu, 14 Aug 2014 09:09:59 +0200 [thread overview]
Message-ID: <53EC60C7.6020602@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1408140939240.1752@ja.home.ssi.bg>
On 08/14/2014 09:02 AM, Julian Anastasov wrote:
>
> Hello,
>
> On Wed, 13 Aug 2014, Alex Gartrell wrote:
>
>> Here's a basic python framework for doing selftests on ipvs.
>
> This is interesting work. I, personally, didn't
> played with such kind of tools, so if you don't get other
> response here feel free to contact netdev, DaveM,
> Andrew Morton or even Linus for applying the patch.
> I don't know if some part of the code (IPv4/IPv6 headers)
> can be useful for other future tests, so CC-ing netdev
> would be a good idea.
Agreed, that's great to have a selftest suite for ipvs!
One minor note, for networking there is so far a small set
of tests under tools/testing/selftests/net/ .
You might want to consider adding it there and reorganizing
the structure as follows, for example:
tools/testing/selftests/net/ipvs/ -- your code
tools/testing/selftests/net/packet/ -- for existing psock* tests
tools/testing/selftests/net/misc/ -- general socket tests
net-next is currently closed due to the merge window, but
development should open very soon again, Dave always announces
this on netdev.
>> Signed-off-by: Alex Gartrell <agartrell@fb.com>
>> ---
>> tools/testing/selftests/ipvs/.gitignore | 1 +
>> tools/testing/selftests/ipvs/Makefile | 14 +
>> tools/testing/selftests/ipvs/general_ipvs_tests.py | 87 ++++++
>> tools/testing/selftests/ipvs/network_headers.py | 315 +++++++++++++++++++++
>> tools/testing/selftests/ipvs/network_test_utils.py | 93 ++++++
>> tools/testing/selftests/ipvs/test-ipvs.py | 17 ++
>> 6 files changed, 527 insertions(+)
>> create mode 100644 tools/testing/selftests/ipvs/.gitignore
>> create mode 100644 tools/testing/selftests/ipvs/Makefile
>> create mode 100644 tools/testing/selftests/ipvs/general_ipvs_tests.py
>> create mode 100644 tools/testing/selftests/ipvs/network_headers.py
>> create mode 100644 tools/testing/selftests/ipvs/network_test_utils.py
>> create mode 100644 tools/testing/selftests/ipvs/test-ipvs.py
>
> Regards
>
> --
> Julian Anastasov <ja@ssi.bg>
> --
> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-08-14 7:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 2:12 [PATCH ipvs] ipvs: Add selftests for ipvs Alex Gartrell
2014-08-14 7:02 ` Julian Anastasov
2014-08-14 7:09 ` Daniel Borkmann [this message]
2014-08-14 16:51 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EC60C7.6020602@redhat.com \
--to=dborkman@redhat.com \
--cc=agartrell@fb.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kernel-team@fb.com \
--cc=lvs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.