From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 7D026610F5 for ; Thu, 14 Aug 2014 08:55:01 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.9/8.14.5) with ESMTP id s7E8t1nE013212 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 14 Aug 2014 01:55:01 -0700 (PDT) Received: from [128.224.162.231] (128.224.162.231) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 14 Aug 2014 01:55:01 -0700 Message-ID: <53EC7964.5050504@windriver.com> Date: Thu, 14 Aug 2014 16:55:00 +0800 From: Kang Kai User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: , Martin Jansa References: <1408002596-9778-1-git-send-email-kai.kang@windriver.com> <53EC6CFA.9050406@windriver.com> <20140814083809.GD14848@jama> <53EC766B.8090402@windriver.com> <20140814085201.GF14848@jama> In-Reply-To: <20140814085201.GF14848@jama> X-Originating-IP: [128.224.162.231] X-Content-Filtered-By: Mailman/MimeDel 2.1.12 Subject: Re: [meta-perl][PATCH 1/6] libdigest-sha1-perl: add recipe X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2014 08:55:03 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 2014?08?14? 16:52, Martin Jansa wrote: > On Thu, Aug 14, 2014 at 04:42:19PM +0800, Kang Kai wrote: >> On 2014?08?14? 16:38, Martin Jansa wrote: >>> On Thu, Aug 14, 2014 at 04:02:02PM +0800, Kang Kai wrote: >>>> This series of commits is for layer *meta-perl*, and I add it in cover >>>> letter created by 'git send-email --compose', but it seems doesn't work. >>> Please update indentation in them, you're using mix of tabs and spaces >>> -> use 4 spaces everywhere. >> Even in the shell function, such as >> >> +do_install_ptest () { >> + cp -r ${B}/t ${D}${PTEST_PATH} >> +} >> >> >> I just thought it should be indented with tab. > Yes, tabs in shell tasks are used only by oe-core, meta-oe, meta-smartphone, meta-qt5, meta-webos, .. > are using consistent styleguide with 4 spaces everywhere. OK. I'll sent V2. Thanks a lot. --Kai > >> If so, I'll update them and send V2. >> >> Thanks, >> Kai >> >>>> On 2014?08?14? 15:49, Kai Kang wrote: >>>> >>>> >>>>> Add recipe for libdigest-sha1-perl and enable create -ptest sub-package. >>>>> >>>>> Signed-off-by: Kai Kang >>>>> --- >>>>> meta-perl/recipes-perl/libdigest/files/run-ptest | 16 ++++++++++++++ >>>>> .../libdigest/libdigest-sha1-perl_2.13.bb | 25 ++++++++++++++++++++++ >>>>> 2 files changed, 41 insertions(+) >>>>> create mode 100644 meta-perl/recipes-perl/libdigest/files/run-ptest >>>>> create mode 100644 meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.13.bb >>>>> >>>>> diff --git a/meta-perl/recipes-perl/libdigest/files/run-ptest b/meta-perl/recipes-perl/libdigest/files/run-ptest >>>>> new file mode 100644 >>>>> index 0000000..1c008b5 >>>>> --- /dev/null >>>>> +++ b/meta-perl/recipes-perl/libdigest/files/run-ptest >>>>> @@ -0,0 +1,16 @@ >>>>> +#!/bin/sh >>>>> + >>>>> +for case in `find t -type f -name '*.t'`; do >>>>> + perl $case >$case.output 2>&1 >>>>> + ret=$? >>>>> + cat $case.output >>>>> + if [ $ret -ne 0 ]; then >>>>> + echo "FAIL: ${case%.t}" >>>>> + elif grep -i 'SKIP' $case.output; then >>>>> + echo "SKIP: ${case%.t}" >>>>> + else >>>>> + echo "PASS: ${case%.t}" >>>>> + fi >>>>> + >>>>> + rm -f $case.output >>>>> +done >>>>> diff --git a/meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.13.bb b/meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.13.bb >>>>> new file mode 100644 >>>>> index 0000000..42d5875 >>>>> --- /dev/null >>>>> +++ b/meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.13.bb >>>>> @@ -0,0 +1,25 @@ >>>>> +SUMMARY = "Perl interface to the SHA-1 algorithm " >>>>> +DESCRIPTION = "Digest::SHA1 - Perl interface to the SHA-1 algorithm" >>>>> +HOMEPAGE = "http://search.cpan.org/~gaas/Digest-SHA1-2.13/" >>>>> +SECTION = "libs" >>>>> + >>>>> +LICENSE = "Artistic-1.0|GPLv1+" >>>>> +LIC_FILES_CHKSUM = "file://README;beginline=10;endline=14;md5=ff5867ebb4bc1103a7a416aef2fce00a" >>>>> + >>>>> +SRC_URI = "http://search.cpan.org/CPAN/authors/id/G/GA/GAAS/Digest-SHA1-${PV}.tar.gz \ >>>>> + file://run-ptest \ >>>>> + " >>>>> +SRC_URI[md5sum] = "bd22388f268434f2b24f64e28bf1aa35" >>>>> +SRC_URI[sha256sum] = "68c1dac2187421f0eb7abf71452a06f190181b8fc4b28ededf5b90296fb943cc" >>>>> + >>>>> +S = "${WORKDIR}/Digest-SHA1-${PV}" >>>>> + >>>>> +inherit cpan ptest >>>>> + >>>>> +do_install_ptest () { >>>>> + cp -r ${B}/t ${D}${PTEST_PATH} >>>>> +} >>>>> + >>>>> +BBCLASSEXTEND="native" >>>>> + >>>>> +FILES_${PN}-dbg =+ "${libdir}/perl/vendor_perl/*/auto/Digest/SHA1/.debug/" >>>> -- >>>> Regards, >>>> Neil | Kai Kang >>>> >>>> -- >>>> _______________________________________________ >>>> Openembedded-devel mailing list >>>> Openembedded-devel@lists.openembedded.org >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >>> >> >> -- >> Regards, >> Neil | Kai Kang >> >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > -- Regards, Neil | Kai Kang