Re: [PATCH 1/1] net: can: sja1000: Validate initialization state in start method

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]

On 08/08/2014 02:30 PM, Mirza Krak wrote:
> When sja1000 is not compiled as module the SJA1000 chip is only
> initialized during device registration on kernel boot. Should the chip
> get a hardware reset there is no way to reinitialize it without re-
> booting the Linux kernel.

Not good. :/

However, you can manually unbind the device from the driver:

> ➜ (pts/0) mkl@hermippe:drivers/sja1000_plx_pci ll
> total 0
> lrwxrwxrwx 1 root root    0 Aug 14 12:15 0000:01:02.0 -> ../../../../devices/pci0000:00/0000:00:1e.0/0000:01:02.0
> --w------- 1 root root 4096 Aug 14 12:15 bind
> lrwxrwxrwx 1 root root    0 Aug 14 12:15 module -> ../../../../module/plx_pci
> --w------- 1 root root 4096 Aug 14 12:15 new_id
> --w------- 1 root root 4096 Aug 14 12:15 remove_id
> --w------- 1 root root 4096 Aug 14 12:15 uevent
> --w------- 1 root root 4096 Aug 14 12:15 unbind
> ➜ (pts/0) mkl@hermippe:drivers/sja1000_plx_pci echo 0000:01:02.0 | sudo tee unbind

And then rebind it:

> ➜ (pts/0) mkl@hermippe:drivers/sja1000_plx_pci echo 0000:01:02.0 | sudo tee bind

> This patch adds a check in sja1000_start if the chip is initialized, if
> not we initialize it.

Applied to can.

Thanks,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]