From: Alexander Graf <agraf@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2] PC, KVM, CMA: Fix regression caused by wrong get_order() use
Date: Thu, 14 Aug 2014 13:40:59 +0000 [thread overview]
Message-ID: <53ECBC6B.5030507@suse.de> (raw)
In-Reply-To: <87egwj64bz.fsf@linux.vnet.ibm.com>
On 14.08.14 07:13, Aneesh Kumar K.V wrote:
> Alexey Kardashevskiy <aik@ozlabs.ru> writes:
>
>> fc95ca7284bc54953165cba76c3228bd2cdb9591 claims that there is no
>> functional change but this is not true as it calls get_order() (which
>> takes bytes) where it should have called ilog2() and the kernel stops
>> on VM_BUG_ON().
>>
>> This replaces get_order() with order_base_2() (round-up version of ilog2).
>>
>> Suggested-by: Paul Mackerras <paulus@samba.org>
>> Cc: Alexander Graf <agraf@suse.de>
>> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
So this affects 3.17?
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
linuxppc-dev@lists.ozlabs.org
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
Paul Mackerras <paulus@samba.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2] PC, KVM, CMA: Fix regression caused by wrong get_order() use
Date: Thu, 14 Aug 2014 15:40:59 +0200 [thread overview]
Message-ID: <53ECBC6B.5030507@suse.de> (raw)
In-Reply-To: <87egwj64bz.fsf@linux.vnet.ibm.com>
On 14.08.14 07:13, Aneesh Kumar K.V wrote:
> Alexey Kardashevskiy <aik@ozlabs.ru> writes:
>
>> fc95ca7284bc54953165cba76c3228bd2cdb9591 claims that there is no
>> functional change but this is not true as it calls get_order() (which
>> takes bytes) where it should have called ilog2() and the kernel stops
>> on VM_BUG_ON().
>>
>> This replaces get_order() with order_base_2() (round-up version of ilog2).
>>
>> Suggested-by: Paul Mackerras <paulus@samba.org>
>> Cc: Alexander Graf <agraf@suse.de>
>> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
So this affects 3.17?
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2] PC, KVM, CMA: Fix regression caused by wrong get_order() use
Date: Thu, 14 Aug 2014 15:40:59 +0200 [thread overview]
Message-ID: <53ECBC6B.5030507@suse.de> (raw)
In-Reply-To: <87egwj64bz.fsf@linux.vnet.ibm.com>
On 14.08.14 07:13, Aneesh Kumar K.V wrote:
> Alexey Kardashevskiy <aik@ozlabs.ru> writes:
>
>> fc95ca7284bc54953165cba76c3228bd2cdb9591 claims that there is no
>> functional change but this is not true as it calls get_order() (which
>> takes bytes) where it should have called ilog2() and the kernel stops
>> on VM_BUG_ON().
>>
>> This replaces get_order() with order_base_2() (round-up version of ilog2).
>>
>> Suggested-by: Paul Mackerras <paulus@samba.org>
>> Cc: Alexander Graf <agraf@suse.de>
>> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
So this affects 3.17?
Alex
next prev parent reply other threads:[~2014-08-14 13:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 5:03 [PATCH v2] PC, KVM, CMA: Fix regression caused by wrong get_order() use Alexey Kardashevskiy
2014-08-14 5:03 ` Alexey Kardashevskiy
2014-08-14 5:03 ` Alexey Kardashevskiy
2014-08-14 5:13 ` Aneesh Kumar K.V
2014-08-14 5:25 ` Aneesh Kumar K.V
2014-08-14 5:13 ` Aneesh Kumar K.V
2014-08-14 13:40 ` Alexander Graf [this message]
2014-08-14 13:40 ` Alexander Graf
2014-08-14 13:40 ` Alexander Graf
2014-08-15 3:00 ` Alexey Kardashevskiy
2014-08-15 3:00 ` Alexey Kardashevskiy
2014-08-15 3:00 ` Alexey Kardashevskiy
2014-08-20 2:44 ` Joonsoo Kim
2014-08-20 2:44 ` Joonsoo Kim
2014-08-20 2:44 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ECBC6B.5030507@suse.de \
--to=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=gleb@kernel.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.