From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Thu, 14 Aug 2014 13:40:59 +0000 Subject: Re: [PATCH v2] PC, KVM, CMA: Fix regression caused by wrong get_order() use Message-Id: <53ECBC6B.5030507@suse.de> List-Id: References: <1407992587-9164-1-git-send-email-aik@ozlabs.ru> <87egwj64bz.fsf@linux.vnet.ibm.com> In-Reply-To: <87egwj64bz.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Aneesh Kumar K.V" , Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org Cc: Benjamin Herrenschmidt , Paul Mackerras , Gleb Natapov , Paolo Bonzini , Michael Ellerman , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Joonsoo Kim On 14.08.14 07:13, Aneesh Kumar K.V wrote: > Alexey Kardashevskiy writes: > >> fc95ca7284bc54953165cba76c3228bd2cdb9591 claims that there is no >> functional change but this is not true as it calls get_order() (which >> takes bytes) where it should have called ilog2() and the kernel stops >> on VM_BUG_ON(). >> >> This replaces get_order() with order_base_2() (round-up version of ilog2). >> >> Suggested-by: Paul Mackerras >> Cc: Alexander Graf >> Cc: Aneesh Kumar K.V >> Cc: Joonsoo Kim >> Cc: Benjamin Herrenschmidt >> Signed-off-by: Alexey Kardashevskiy > Reviewed-by: Aneesh Kumar K.V So this affects 3.17? Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 19D861A00C9 for ; Thu, 14 Aug 2014 23:41:08 +1000 (EST) Message-ID: <53ECBC6B.5030507@suse.de> Date: Thu, 14 Aug 2014 15:40:59 +0200 From: Alexander Graf MIME-Version: 1.0 To: "Aneesh Kumar K.V" , Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2] PC, KVM, CMA: Fix regression caused by wrong get_order() use References: <1407992587-9164-1-git-send-email-aik@ozlabs.ru> <87egwj64bz.fsf@linux.vnet.ibm.com> In-Reply-To: <87egwj64bz.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Cc: kvm@vger.kernel.org, Gleb Natapov , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , Paolo Bonzini , Joonsoo Kim List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 14.08.14 07:13, Aneesh Kumar K.V wrote: > Alexey Kardashevskiy writes: > >> fc95ca7284bc54953165cba76c3228bd2cdb9591 claims that there is no >> functional change but this is not true as it calls get_order() (which >> takes bytes) where it should have called ilog2() and the kernel stops >> on VM_BUG_ON(). >> >> This replaces get_order() with order_base_2() (round-up version of ilog2). >> >> Suggested-by: Paul Mackerras >> Cc: Alexander Graf >> Cc: Aneesh Kumar K.V >> Cc: Joonsoo Kim >> Cc: Benjamin Herrenschmidt >> Signed-off-by: Alexey Kardashevskiy > Reviewed-by: Aneesh Kumar K.V So this affects 3.17? Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH v2] PC, KVM, CMA: Fix regression caused by wrong get_order() use Date: Thu, 14 Aug 2014 15:40:59 +0200 Message-ID: <53ECBC6B.5030507@suse.de> References: <1407992587-9164-1-git-send-email-aik@ozlabs.ru> <87egwj64bz.fsf@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Benjamin Herrenschmidt , Paul Mackerras , Gleb Natapov , Paolo Bonzini , Michael Ellerman , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Joonsoo Kim To: "Aneesh Kumar K.V" , Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org Return-path: In-Reply-To: <87egwj64bz.fsf@linux.vnet.ibm.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 14.08.14 07:13, Aneesh Kumar K.V wrote: > Alexey Kardashevskiy writes: > >> fc95ca7284bc54953165cba76c3228bd2cdb9591 claims that there is no >> functional change but this is not true as it calls get_order() (which >> takes bytes) where it should have called ilog2() and the kernel stops >> on VM_BUG_ON(). >> >> This replaces get_order() with order_base_2() (round-up version of ilog2). >> >> Suggested-by: Paul Mackerras >> Cc: Alexander Graf >> Cc: Aneesh Kumar K.V >> Cc: Joonsoo Kim >> Cc: Benjamin Herrenschmidt >> Signed-off-by: Alexey Kardashevskiy > Reviewed-by: Aneesh Kumar K.V So this affects 3.17? Alex