All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Sébastien Barré" <sebastien.barre@uclouvain.be>,
	"David Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Gregory Detal <gregory.detal@uclouvain.be>
Subject: Re: [PATCH] ipv4: Restore accept_local behaviour in fib_validate_source()
Date: Thu, 14 Aug 2014 17:51:28 +0400	[thread overview]
Message-ID: <53ECBEE0.7000802@cogentembedded.com> (raw)
In-Reply-To: <1408020352-22841-1-git-send-email-sebastien.barre@uclouvain.be>

Hello.

On 08/14/2014 04:45 PM, Sébastien Barré wrote:

> Commit 7a9bc9b introduced a short-circuit to avoid calling

    Please also specify that commit's summary line in parens.

> fib_validate_source when not needed. That change took rp_filter
> into account, but not accept_local. This resulted in a change
> of behaviour: with rp_filter and accept_local off, incoming
> packets with a local address in the source field should be
> dropped.

> Here is how to reproduce the change pre/post 7a9bc9b commit:
> -configure the same IPv4 address on hosts A and B.
> -try to send an arp request from B to A.
> -The arp request will be dropped before commit 7a9bc9b,

    s/arp/ARP/?

> but accepted and answered after that commit.

> This adds a check for ACCEPT_LOCAL, to maintain full
> fib validation in case it is 0.

> Signed-off-by: Sébastien Barré <sebastien.barre@uclouvain.be>

WBR, Sergei

      parent reply	other threads:[~2014-08-14 13:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 12:45 [PATCH] ipv4: Restore accept_local behaviour in fib_validate_source() Sébastien Barré
2014-08-14 13:36 ` Hannes Frederic Sowa
2014-08-14 13:51 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53ECBEE0.7000802@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=gregory.detal@uclouvain.be \
    --cc=netdev@vger.kernel.org \
    --cc=sebastien.barre@uclouvain.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.