All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Dmitry Monakhov <dmonakhov@openvz.org>, fstests@vger.kernel.org
Cc: david@fromorbit.com
Subject: Re: [PATCH 1/2] xfstest: shared/298 fixup mkfs options
Date: Thu, 14 Aug 2014 10:08:46 -0700	[thread overview]
Message-ID: <53ECED1E.4070106@sandeen.net> (raw)
In-Reply-To: <1407944188-4099-1-git-send-email-dmonakhov@openvz.org>

On 8/13/14, 8:36 AM, Dmitry Monakhov wrote:
> Currently mkfs faile due to incorrect options

fails how, for what fs, with what options?

Thanks,
-Eric

> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
>  tests/shared/298 |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/shared/298 b/tests/shared/298
> index 372fd02..685ba27 100755
> --- a/tests/shared/298
> +++ b/tests/shared/298
> @@ -134,8 +134,8 @@ mkdir $loop_mnt
>  
>  [ "$FSTYP" = "xfs" ] && MKFS_OPTIONS="-f $MKFS_OPTIONS"
>  
> -$MKFS_PROG -t $FSTYP $MKFS_OPTIONS $loop_dev &> /dev/null
> -$MOUNT_PROG $loop_dev $loop_mnt
> +run_check $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $loop_dev
> +run_check $MOUNT_PROG $loop_dev $loop_mnt
>  
>  echo -n "Generating garbage on loop..."
>  # Goal is to fill it up, ignore any errors.
> 


  parent reply	other threads:[~2014-08-14 17:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13 15:36 [PATCH 1/2] xfstest: shared/298 fixup mkfs options Dmitry Monakhov
2014-08-13 15:36 ` [PATCH 2/2] xfstest: ext4/307 cleanup Dmitry Monakhov
2014-08-14 14:22   ` Lukáš Czerner
2014-08-15 10:42     ` Dmitry Monakhov
2014-08-15 10:51       ` Lukáš Czerner
2014-08-14 14:13 ` [PATCH 1/2] xfstest: shared/298 fixup mkfs options Lukáš Czerner
2014-08-14 17:08 ` Eric Sandeen [this message]
2014-08-15 10:20   ` Dmitry Monakhov
2014-08-15  0:44 ` Dave Chinner
2014-08-15 10:30   ` Dmitry Monakhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53ECED1E.4070106@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=david@fromorbit.com \
    --cc=dmonakhov@openvz.org \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.