All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/3] bootm: use genimg_get_kernel_addr()
Date: Thu, 14 Aug 2014 18:00:31 -0700	[thread overview]
Message-ID: <53ED5BAF.6070003@freescale.com> (raw)
In-Reply-To: <1407199408-4348-4-git-send-email-pengw@nvidia.com>

On 08/04/2014 05:43 PM, Bryan Wu wrote:
> Use the new API which is originally taken out from boot_get_kernel
> of bootm.c
> 
> Signed-off-by: Bryan Wu <pengw@nvidia.com>
> Tested-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
> ---
>  common/bootm.c | 25 +++++--------------------
>  1 file changed, 5 insertions(+), 20 deletions(-)
> 
> diff --git a/common/bootm.c b/common/bootm.c
> index 7ec2ed8..621bff2 100644
> --- a/common/bootm.c
> +++ b/common/bootm.c

<snip>

>  	bootstage_mark(BOOTSTAGE_ID_CHECK_MAGIC);
>  
> @@ -807,6 +788,10 @@ static const void *boot_get_kernel(cmd_tbl_t *cmdtp, int flag, int argc,
>  #endif
>  #if defined(CONFIG_FIT)
>  	case IMAGE_FORMAT_FIT:
> +		if (!fit_parse_conf(argv[0], load_addr, &img_addr,
> +					fit_uname_config))
> +			fit_parse_subimage(argv[0], load_addr, &img_addr,
> +					fit_uname_kernel);
>  		os_noffset = fit_image_load(images, img_addr,
>  				&fit_uname_kernel, &fit_uname_config,
>  				IH_ARCH_DEFAULT, IH_TYPE_KERNEL,
> 

Did anyone test this addition? It breaks my booting. The variable img_addr get
changed for calling fit_parse_conf(). If I don't use load_addr variable and run
"bootm <addr>" with a FIT image, this will fail. It took me hours to figure out.

Why is this change needed? What does it fix?

York

  parent reply	other threads:[~2014-08-15  1:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05  0:43 [U-Boot] [PATCH v2 0/3] introduce genimg_get_kernel_addr() Bryan Wu
2014-08-05  0:43 ` [U-Boot] [PATCH v2 1/3] image: " Bryan Wu
2014-08-05 12:07   ` Simon Glass
2014-08-05  0:43 ` [U-Boot] [PATCH v2 2/3] pxe: detect image format before calling bootm/bootz Bryan Wu
2014-08-05  0:43 ` [U-Boot] [PATCH v2 3/3] bootm: use genimg_get_kernel_addr() Bryan Wu
2014-08-05 12:08   ` Simon Glass
2014-08-15  1:00   ` York Sun [this message]
2014-08-15  1:05     ` Bryan Wu
2014-08-15  1:15       ` York Sun
2014-08-15  1:38     ` Tom Rini
2014-08-15  1:42       ` York Sun
2014-08-15  3:48         ` Simon Glass
2014-08-15  4:02           ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53ED5BAF.6070003@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.