From: Ding Tianhong <dingtianhong@huawei.com>
To: David Miller <davem@redhat.com>, <eric.dumazet@gmail.com>
Cc: <cwang@twopensource.com>, <jacob.e.keller@intel.com>,
<kaber@trash.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net] macvlan: Fix the bug when destroy macvlan dev port
Date: Fri, 15 Aug 2014 09:41:50 +0800 [thread overview]
Message-ID: <53ED655E.6090309@huawei.com> (raw)
In-Reply-To: <20140814.143236.466435177296125156.davem@redhat.com>
On 2014/8/15 5:32, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Thu, 14 Aug 2014 10:38:30 -0700
>
>> On Thu, 2014-08-14 at 09:58 -0700, Cong Wang wrote:
>>> On Thu, Aug 14, 2014 at 2:12 AM, Ding Tianhong <dingtianhong@huawei.com> wrote:
>>>>
>>>> To fix this problem, we need to check whether the port is exist when calling
>>>> macvlan_port_destroy(), do nothing if the port has been destroyed yet.
>>>>
>>>
>>> As I said, this will make the first call of macvlan_port_destroy()
>>> free the port,
>>> which was freed by the last one before.
>>>
>>> Why not just revert your change? It doesn't give any benefit.
>>> --
>>
>> Yes please, I think patch should be reverted.
>
> I agree, this should be reverted, I'm going to do it myself.
>
>
Ok, sorry to trouble you.
>
> .
>
prev parent reply other threads:[~2014-08-15 1:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 9:12 [PATCH net] macvlan: Fix the bug when destroy macvlan dev port Ding Tianhong
2014-08-14 16:58 ` Cong Wang
2014-08-14 17:38 ` Eric Dumazet
2014-08-14 20:32 ` Keller, Jacob E
2014-08-14 21:32 ` David Miller
2014-08-15 1:41 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ED655E.6090309@huawei.com \
--to=dingtianhong@huawei.com \
--cc=cwang@twopensource.com \
--cc=davem@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.