From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly Date: Fri, 15 Aug 2014 17:01:20 +0800 Message-ID: <53EDCC60.5040608@gmail.com> References: <53ECE9DD.80004@gmail.com> <20140814180418.GA20777@linux-mips.org> <53ED34CE.3040001@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=VOeqw/n7UCD7wMmRLxfit5rey0ZmaJSVDygLXIGaB9g=; b=k3IYshbANurNxjIxvmqWAvWiikaWtHUqR+X+lmAlJjP/5jTWFLA6JGaODj+yzfwRzH BQFxBwglwpSJsVpmIEh5kO0DzTLWDCvZ7V3YMlMBLAHeO+stYkx1efLOLodmM7/W6ImM hurylFKXCDDO60sx9S49EFiYYEkbYPVCcalacUTq7NrnfAG2GyaLSP95H+Gw6D6ZGpfU jNOFq6CLFoQz51CKrGF10RJLaISITtyXAAOglQlaKuxhA0JGZGpEkEcGTyg9KUR0AnzH tlmnQlzXLwoq5U5N3t4cCuIbFZOdLRPbE8GjK8rUb35i9UobGEMan/XD1F2MeMCc54NO 5dQQ== In-Reply-To: <53ED34CE.3040001@gmail.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: List-subscribe: List-owner: List-post: List-archive: Content-Type: text/plain; charset="us-ascii" To: Ralf Baechle Cc: Arnd Bergmann , akpm@linux-foundation.org, rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@synopsys.com, Geert Uytterhoeven , Jean Delvare , linux@arm.linux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, hskinnemoen@gmail.com, egtvedt@samfundet.no, realmz6@gmail.com, msalter@redhat.com, a-jacquiot@ti.com, starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com, rkuo@codeaurora.org, tony.luck@intel.com, fenghua.yu@intel.com, takata@linux-m32r.org, james.hogan@imgtec.com, Michal Simek , yasutake.koichi@jp.panasonic.com, jonas@southpole.se, jejb@parisc-linux.org, deller@gmx.de, Benjamin Herrenschmidt , paulus@samba.org, mpe@ellerman.id.au, Mart On 8/15/14 6:14, Chen Gang wrote: > On 08/15/2014 02:04 AM, Ralf Baechle wrote: >> > > OK, thanks, I assumes when support both endian, the default choice is > CPU_BIG_ENDIAN, although no default value for choice (originally, I did > worry about it). > >> So I think you can just drop the MIPS segment from your patch. >> > > If what I assumes is correct, what you said sounds reasonable to me. > > So for me, it is harmless to add CPU_*_ENDIAN explicitly, and can let other members don't need think of. By the way, for sh, it is almost the same case, except it contents the default value, for me, it is clear enough, so I skip sh architecture in this patch. Thanks -- Chen Gang Open, share, and attitude like air, water, and life which God blessed From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 15 Aug 2014 10:57:23 +0200 (CEST) Received: from mail-pa0-f49.google.com ([209.85.220.49]:42236 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6816855AbaHOI5NOV8We (ORCPT ); Fri, 15 Aug 2014 10:57:13 +0200 Received: by mail-pa0-f49.google.com with SMTP id hz1so3160668pad.22 for ; Fri, 15 Aug 2014 01:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=VOeqw/n7UCD7wMmRLxfit5rey0ZmaJSVDygLXIGaB9g=; b=k3IYshbANurNxjIxvmqWAvWiikaWtHUqR+X+lmAlJjP/5jTWFLA6JGaODj+yzfwRzH BQFxBwglwpSJsVpmIEh5kO0DzTLWDCvZ7V3YMlMBLAHeO+stYkx1efLOLodmM7/W6ImM hurylFKXCDDO60sx9S49EFiYYEkbYPVCcalacUTq7NrnfAG2GyaLSP95H+Gw6D6ZGpfU jNOFq6CLFoQz51CKrGF10RJLaISITtyXAAOglQlaKuxhA0JGZGpEkEcGTyg9KUR0AnzH tlmnQlzXLwoq5U5N3t4cCuIbFZOdLRPbE8GjK8rUb35i9UobGEMan/XD1F2MeMCc54NO 5dQQ== X-Received: by 10.66.139.232 with SMTP id rb8mr10473263pab.130.1408093025145; Fri, 15 Aug 2014 01:57:05 -0700 (PDT) Received: from [192.168.2.114] ([124.127.118.42]) by mx.google.com with ESMTPSA id zh7sm25873054pab.1.2014.08.15.01.56.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Aug 2014 01:57:04 -0700 (PDT) Message-ID: <53EDCC60.5040608@gmail.com> Date: Fri, 15 Aug 2014 17:01:20 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Ralf Baechle CC: Arnd Bergmann , akpm@linux-foundation.org, rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@synopsys.com, Geert Uytterhoeven , Jean Delvare , linux@arm.linux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, hskinnemoen@gmail.com, egtvedt@samfundet.no, realmz6@gmail.com, msalter@redhat.com, a-jacquiot@ti.com, starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com, rkuo@codeaurora.org, tony.luck@intel.com, fenghua.yu@intel.com, takata@linux-m32r.org, james.hogan@imgtec.com, Michal Simek , yasutake.koichi@jp.panasonic.com, jonas@southpole.se, jejb@parisc-linux.org, deller@gmx.de, Benjamin Herrenschmidt , paulus@samba.org, mpe@ellerman.id.au, Martin Schwidefsky , heiko.carstens@de.ibm.com, Liqin Chen , Lennox Wu , "David S. Miller" , cmetcalf@tilera.com, jdike@addtoit.com, Richard Weinberger , gxt@mprc.pku.edu.cn, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, linux390@de.ibm.com, x86@kernel.org, linux-alpha@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linux-c6x-dev@linux-c6x.org, linux-cris-kernel@axis.com, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, linux-m68k@vger.kernel.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, linux-am33-list@redhat.com, linux@openrisc.net, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org Subject: Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly References: <53ECE9DD.80004@gmail.com> <20140814180418.GA20777@linux-mips.org> <53ED34CE.3040001@gmail.com> In-Reply-To: <53ED34CE.3040001@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 42118 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: gang.chen.5i5j@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 8/15/14 6:14, Chen Gang wrote: > On 08/15/2014 02:04 AM, Ralf Baechle wrote: >> > > OK, thanks, I assumes when support both endian, the default choice is > CPU_BIG_ENDIAN, although no default value for choice (originally, I did > worry about it). > >> So I think you can just drop the MIPS segment from your patch. >> > > If what I assumes is correct, what you said sounds reasonable to me. > > So for me, it is harmless to add CPU_*_ENDIAN explicitly, and can let other members don't need think of. By the way, for sh, it is almost the same case, except it contents the default value, for me, it is clear enough, so I skip sh architecture in this patch. Thanks -- Chen Gang Open, share, and attitude like air, water, and life which God blessed From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-x22c.google.com (mail-pa0-x22c.google.com [IPv6:2607:f8b0:400e:c03::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CC7D11A001C for ; Fri, 15 Aug 2014 18:57:08 +1000 (EST) Received: by mail-pa0-f44.google.com with SMTP id eu11so3180143pac.31 for ; Fri, 15 Aug 2014 01:57:06 -0700 (PDT) Message-ID: <53EDCC60.5040608@gmail.com> Date: Fri, 15 Aug 2014 17:01:20 +0800 From: Chen Gang MIME-Version: 1.0 To: Ralf Baechle Subject: Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly References: <53ECE9DD.80004@gmail.com> <20140814180418.GA20777@linux-mips.org> <53ED34CE.3040001@gmail.com> In-Reply-To: <53ED34CE.3040001@gmail.com> Content-Type: text/plain; charset=windows-1252 Cc: linux-m32r-ja@ml.linux-m32r.org, linux-mips@linux-mips.org, linux-m68k@vger.kernel.org, a-jacquiot@ti.com, catalin.marinas@arm.com, linux@openrisc.net, will.deacon@arm.com, dhowells@redhat.com, jcmvbkbc@gmail.com, paulus@samba.org, hpa@zytor.com, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-s390@vger.kernel.org, gxt@mprc.pku.edu.cn, Jean Delvare , egtvedt@samfundet.no, jonas@southpole.se, Liqin Chen , jesper.nilsson@axis.com, linux-am33-list@redhat.com, linux@arm.linux.org.uk, linux-c6x-dev@linux-c6x.org, "David S. Miller" , linux-xtensa@linux-xtensa.org, takata@linux-m32r.org, x86@kernel.org, jejb@parisc-linux.org, linux-sh@vger.kernel.org, mingo@redhat.com, Geert Uytterhoeven , Lennox Wu , msalter@redhat.com, mattst88@gmail.com, hskinnemoen@gmail.com, fenghua.yu@intel.com, james.hogan@imgtec.com, Arnd Bergmann , realmz6@gmail.com, heiko.carstens@de.ibm.com, jdike@addtoit.com, linux-alpha@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, cmetcalf@tilera.com, starvik@axis.com, linux-m32r@ml.linux-m32r.org, ink@jurassic.park.msu.ru, user-mode-linux-user@lists.sourceforge.net, tglx@linutronix.de, linux-metag@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rth@twiddle.net, chris@zankel.net, Michal Simek , tony.luck@intel.com, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com, vgupta@synopsys.com, "linux-kernel@vger.kernel.org" , rkuo@codeaurora.org, user-mode-linux-devel@lists.sourceforge.net, Richard Weinberger , Martin Schwidefsky , linux390@de.ibm.com, akpm@linux-foundation.org, yasutake.koichi@jp.panasonic.com, linuxppc-dev@lists.ozlabs.org, deller@gmx.de List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 8/15/14 6:14, Chen Gang wrote: > On 08/15/2014 02:04 AM, Ralf Baechle wrote: >> > > OK, thanks, I assumes when support both endian, the default choice is > CPU_BIG_ENDIAN, although no default value for choice (originally, I did > worry about it). > >> So I think you can just drop the MIPS segment from your patch. >> > > If what I assumes is correct, what you said sounds reasonable to me. > > So for me, it is harmless to add CPU_*_ENDIAN explicitly, and can let other members don't need think of. By the way, for sh, it is almost the same case, except it contents the default value, for me, it is clear enough, so I skip sh architecture in this patch. Thanks -- Chen Gang Open, share, and attitude like air, water, and life which God blessed