From: Chris Mason <clm@fb.com>
To: Liu Bo <bo.li.liu@oracle.com>, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3] Btrfs: fix task hang under heavy compressed write
Date: Fri, 15 Aug 2014 12:05:00 -0400 [thread overview]
Message-ID: <53EE2FAC.7080704@fb.com> (raw)
In-Reply-To: <1408117013-305-1-git-send-email-bo.li.liu@oracle.com>
On 08/15/2014 11:36 AM, Liu Bo wrote:
[ snip ]
>
> Besides, there're other cases that can lead to deadlock, but the real problem
> is that all btrfs workqueue shares one work->func, -- normal_work_helper,
> so this makes each workqueue to have its own helper function, but only a
> wraper pf normal_work_helper.
>
> With this patch, I no long hit the above hang.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
> ---
> v3:
> - Adopting Chris's advice, this has each workqueue provide its own helper
> function.
> - This is rebased on the latest Chris's for-linus branch.
This is what I had in mind, thanks Liu! I'll test and queue it up for rc2.
-chris
next prev parent reply other threads:[~2014-08-15 16:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 7:44 [PATCH] Btrfs: fix task hang under heavy compressed write Liu Bo
2014-08-12 14:35 ` [PATCH v2] " Liu Bo
2014-08-12 14:57 ` [PATCH] " Chris Mason
2014-08-13 0:53 ` Qu Wenruo
2014-08-13 11:54 ` Martin Steigerwald
2014-08-13 13:27 ` Rich Freeman
2014-08-13 15:20 ` Liu Bo
2014-08-14 9:27 ` Martin Steigerwald
2014-08-15 17:51 ` Martin Steigerwald
2014-08-15 15:36 ` [PATCH v3] " Liu Bo
2014-08-15 16:05 ` Chris Mason [this message]
2014-08-16 7:28 ` Miao Xie
2014-08-18 7:32 ` Liu Bo
2014-08-25 14:58 ` Chris Mason
2014-08-25 15:19 ` Liu Bo
2014-08-26 10:20 ` Martin Steigerwald
2014-08-26 10:38 ` Liu Bo
2014-08-26 12:04 ` Martin Steigerwald
2014-08-26 13:02 ` Chris Mason
2014-08-26 13:20 ` Martin Steigerwald
2014-08-31 11:48 ` Martin Steigerwald
2014-08-31 15:40 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EE2FAC.7080704@fb.com \
--to=clm@fb.com \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.