From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Fri, 15 Aug 2014 09:34:15 -0700 Subject: [U-Boot] [PATCH v7 5/5] RFC: Deprecate MAKEALL In-Reply-To: <53EE333B.1070307@wwwdotorg.org> References: <1408059307-13829-1-git-send-email-sjg@chromium.org> <1408059307-13829-6-git-send-email-sjg@chromium.org> <53EE2B46.1080805@wwwdotorg.org> <53EE333B.1070307@wwwdotorg.org> Message-ID: <53EE3687.50008@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/15/2014 09:20 AM, Stephen Warren wrote: > On 08/15/2014 10:13 AM, Simon Glass wrote: >> Hi Stephen, >> >> On 15 August 2014 09:46, Stephen Warren wrote: >>> >>> On 08/14/2014 05:35 PM, Simon Glass wrote: >>>> >>>> Since buildman now includes most of the features of MAKEALL it is probably >>>> time to talk about deprecating MAKEALL. >>> >>> >>> I guess I don't care too much, but I would like to point out that when I mentioned the annoyance of having to change my scripts: >>> >>> from: >>> make ARCH=arm jetson_tk1_config >>> >>> to: >>> make ARCH=arm jetson_tk1_defconfig >>> >>> ... together with having to detect which version to use since different U-Boot commits required a difference command, one of the answers was that "MAKEALL jetson_tk1" still worked the same on both old and new git commits, and could be used as a replacement. This patch would invalidate that. >> >> Well I suppose you could use: >> >> ./tools/buildman/buildman jetson_tk1 >> >> to get the same effect. > > True, although that command has been available for a much shorter time > than MAKEALL... > > Replacing the MAKEALL script body with a call to buildman might solve > that? I'm not sure that buildman puts the build results in the same place. > > But like I said, I'm not too worried about this personally, so there's > probably no need to change anything. > I heavily rely on MAKEALL. I have tested buildman recently to confirm it has most features I need to replace MAKEALL with some command line switches. But I need to adjust my testing due to some difference 1) The log is different I can see the err log file, but not the regular log. Buildman runs silently by default. 2) The return value of buildman doesn't tell if an error happens. I have to search for err file to identify if any error. I only tested the features I used most. York