All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 14/15] tegra: dts: Add serial port details
Date: Fri, 15 Aug 2014 11:10:44 -0600	[thread overview]
Message-ID: <53EE3F14.1010804@wwwdotorg.org> (raw)
In-Reply-To: <1407770874-12749-15-git-send-email-sjg@chromium.org>

On 08/11/2014 09:27 AM, Simon Glass wrote:
> Some Tegra device tree files do not include information about the serial
> ports. Add this and also add information about the input clock speed.
>
> The console alias needs to be set up to indicate which port is used for
> the console.
>
> Also add a binding file since this is missing.

> diff --git a/arch/arm/dts/tegra114-dalmore.dts b/arch/arm/dts/tegra114-dalmore.dts

>   	aliases {
> +		console = &uart_d;

Did the use of "console" get OK'd on the devicetree mailing list then?

I know we have this bug in the kernel DTs, but let's fix it here: 
phandle values should have <> around them:

		console = <&uart_d>;

> diff --git a/arch/arm/dts/tegra114.dtsi b/arch/arm/dts/tegra114.dtsi

> +	uart_a: serial at 70006000 {
> +		compatible = "nvidia,tegra20-uart";
> +		reg = <0x70006000 0x40>;
> +		reg-shift = <2>;
> +		interrupts = < 68 >;
> +	};

In order to prevent the kernel and U-Boot DT files from diverging, can 
you copy the entire DT content from the kernel rather than just a 
subset, i.e.:

         uarta: serial at 70006000 {
                 compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart";
                 reg = <0x70006000 0x40>;
                 reg-shift = <2>;
                 interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
                 clocks = <&tegra_car TEGRA114_CLK_UARTA>;
                 resets = <&tegra_car 6>;
                 reset-names = "serial";
                 dmas = <&apbdma 8>, <&apbdma 8>;
                 dma-names = "rx", "tx";
                 status = "disabled";
         };

  reply	other threads:[~2014-08-15 17:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 15:27 [U-Boot] [PATCH v4 0/15] Introduce driver model serial uclass Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 01/15] serial: Set up the 'priv' pointer when creating a serial device Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 02/15] dm: Adjust lists_bind_fdt() to return the bound device Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 03/15] dm: Add a uclass for serial devices Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 04/15] Set up stdio earlier when using driver model Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 05/15] sandbox: Convert serial driver to use " Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 06/15] sandbox: serial: Support a coloured console Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 07/15] sandbox: dts: Add a serial console node Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 08/15] dm: exynos: Mark exynos5 console as pre-reloc Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 09/15] dm: exynos: Move serial to driver model Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 10/15] dm: Make driver model available before board_init() Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 11/15] dm: serial: Move baud rate calculation to ns16550.c Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 12/15] dm: serial: Collect common baud rate code in ns16550 Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 13/15] dm: serial: Add driver model support for ns16550 Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 14/15] tegra: dts: Add serial port details Simon Glass
2014-08-15 17:10   ` Stephen Warren [this message]
2014-08-15 17:25     ` Simon Glass
2014-08-15 17:29       ` Stephen Warren
2014-08-15 17:30         ` Simon Glass
2014-08-11 15:27 ` [U-Boot] [PATCH v4 15/15] dm: tegra: Enable driver model for serial Simon Glass
2014-08-14 22:25   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EE3F14.1010804@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.