From: Jens Axboe <axboe@kernel.dk>
To: Sagi Grimberg <sagig@mellanox.com>, martin.petersen@oracle.com
Cc: kmo@daterainc.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Fix BUG_ON when pi errors occur
Date: Fri, 15 Aug 2014 12:47:37 -0600 [thread overview]
Message-ID: <53EE55C9.7090908@kernel.dk> (raw)
In-Reply-To: <1407930571-26532-1-git-send-email-sagig@mellanox.com>
On 08/13/2014 05:49 AM, Sagi Grimberg wrote:
> When getting a pi error we get to bio_integrity_end_io with
> bi_remaining already decremented to 0 where we will eventually
> need to call bio_endio with restored original bio completion handler.
> Calling bio_endio invokes a BUG_ON(). We should call bio_endio_nodec
> instead, like what is done in bio_integrity_verify_fn.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2014-08-15 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 11:49 [PATCH] block: Fix BUG_ON when pi errors occur Sagi Grimberg
2014-08-15 18:47 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EE55C9.7090908@kernel.dk \
--to=axboe@kernel.dk \
--cc=kmo@daterainc.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagig@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.