Re: [PATCH] macvlan: Allow setting multicast filter on all macvlan types

[John Fastabend <john.r.fastabend@intel.com>]

On 08/15/2014 10:04 AM, Vladislav Yasevich wrote:
> Currently, macvlan code restricts multicast and unicast
> filter setting only to passthru devices.  As a result,
> if a guest using macvtap wants to receive multicast
> traffic, it has to set IFF_ALLMULTI or IFF_PROMISC.
> 
> This patch makes it possible to use the fdb interface
> to add multicast addresses to the filter thus allowing
> a guest to receive only targeted multicast traffic.
> 
> CC: John Fastabend <john.r.fastabend@intel.com>
> CC: Michael S. Tsirkin <mst@redhat.com>
> CC: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
> ---

Acked-by: John Fastabend <john.r.fastabend@intel.com>

Looks good to me. Although I am trying to recall why
we restrict unicast addresses? It looks like an additional
check could be made to detect duplicate MAC addresses
in fdb_add and then we could support this as well. But
I might be missing why this wasn't supported originally.

Thanks,
John