From: Richard Henderson <rth@twiddle.net>
To: Tom Musta <tommusta@gmail.com>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 2/8] target-ppc: Bug Fix: rlwnm
Date: Fri, 15 Aug 2014 09:54:36 -1000 [thread overview]
Message-ID: <53EE657C.7070604@twiddle.net> (raw)
In-Reply-To: <1407785009-6538-3-git-send-email-tommusta@gmail.com>
On 08/11/2014 09:23 AM, Tom Musta wrote:
> +#if defined(TARGET_PPC64)
> + tcg_gen_andi_tl(t0, t0, MASK(32, 63));
> +#endif
Err. this is just simple zero-extension.
> tcg_gen_mov_tl(cpu_gpr[rA(ctx->opcode)], t0);
Why not combine with the mov as
tcg_gen_ext32u_tl
which will just expand to a mov for PPC32.
r~
next prev parent reply other threads:[~2014-08-15 19:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 19:23 [Qemu-devel] [PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions Tom Musta
2014-08-11 19:23 ` [Qemu-devel] [PATCH 1/8] target-ppc: Bug Fix: rlwinm Tom Musta
2014-08-15 18:34 ` Richard Henderson
2014-08-15 19:52 ` Richard Henderson
2014-08-11 19:23 ` [Qemu-devel] [PATCH 2/8] target-ppc: Bug Fix: rlwnm Tom Musta
2014-08-15 19:54 ` Richard Henderson [this message]
2014-08-11 19:23 ` [Qemu-devel] [PATCH 3/8] target-ppc: Bug Fix: rlwimi Tom Musta
2014-08-15 20:05 ` Richard Henderson
2014-08-18 19:51 ` Tom Musta
2014-08-11 19:23 ` [Qemu-devel] [PATCH 4/8] target-ppc: Bug Fix: mullw Tom Musta
2014-08-15 20:07 ` Richard Henderson
2014-08-11 19:23 ` [Qemu-devel] [PATCH 5/8] target-ppc: Bug Fix: mullwo Tom Musta
2014-08-15 20:11 ` Richard Henderson
2014-08-11 19:23 ` [Qemu-devel] [PATCH 6/8] target-ppc: Bug Fix: mulldo OV Detection Tom Musta
2014-08-15 20:16 ` Richard Henderson
2014-08-11 19:23 ` [Qemu-devel] [PATCH 7/8] target-ppc: Bug Fix: srawi Tom Musta
2014-08-11 19:23 ` [Qemu-devel] [PATCH 8/8] target-ppc: Bug Fix: srad Tom Musta
2014-08-15 20:17 ` Richard Henderson
2014-08-12 3:06 ` [Qemu-devel] [PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions David Gibson
2014-08-12 11:40 ` Tom Musta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EE657C.7070604@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=tommusta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.