All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Tom Musta <tommusta@gmail.com>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: agraf@suse.de, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [V2 PATCH 4/8] target-ppc: Bug Fix: mullw
Date: Fri, 15 Aug 2014 10:36:15 -1000	[thread overview]
Message-ID: <53EE6F3F.3050607@twiddle.net> (raw)
In-Reply-To: <1407851110-8075-5-git-send-email-tommusta@gmail.com>

On 08/12/2014 03:45 AM, Tom Musta wrote:
> +#else
>      tcg_gen_mul_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)],
>                     cpu_gpr[rB(ctx->opcode)]);
>      tcg_gen_ext32s_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rD(ctx->opcode)]);
> +#endif

Note that the sign-extension can be dropped, since this is ifdef PPC32.
Perhaps even better to use tcg_gen_mul_i32 explicitly?  That at least
type-checks the arguments are all 32-bit as well.


r~

  reply	other threads:[~2014-08-15 20:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12 13:45 [Qemu-devel] [V2 PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions Tom Musta
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 1/8] target-ppc: Bug Fix: rlwinm Tom Musta
2014-08-15 20:28   ` Richard Henderson
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 2/8] target-ppc: Bug Fix: rlwnm Tom Musta
2014-08-15 20:33   ` Richard Henderson
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 3/8] target-ppc: Bug Fix: rlwimi Tom Musta
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 4/8] target-ppc: Bug Fix: mullw Tom Musta
2014-08-15 20:36   ` Richard Henderson [this message]
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 5/8] target-ppc: Bug Fix: mullwo Tom Musta
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 6/8] target-ppc: Bug Fix: mulldo OV Detection Tom Musta
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 7/8] target-ppc: Bug Fix: srawi Tom Musta
2014-08-15 20:39   ` Richard Henderson
2014-08-12 13:45 ` [Qemu-devel] [V2 PATCH 8/8] target-ppc: Bug Fix: srad Tom Musta
2014-08-12 14:20 ` [Qemu-devel] [V2 PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EE6F3F.3050607@twiddle.net \
    --to=rth@twiddle.net \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=tommusta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.