All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Nadav Amit <namit@cs.technion.ac.il>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Revert "check CS.DPL against RPL during task switch"
Date: Sun, 17 Aug 2014 23:52:41 +0200	[thread overview]
Message-ID: <53F12429.4080103@redhat.com> (raw)
In-Reply-To: <4F071719-C55A-4B18-8F25-47D847311C7D@gmail.com>

Il 17/08/2014 23:33, Nadav Amit ha scritto:
>> > Also, what about the rpl > cpl test below, for non-conforming code
>> > segments?  It is not mentioned in table 6-6 either.
> As far as I understand, after task-switch cpl = cs.rpl. This is how the load_state_from_tss32 does it, and follows SDM 7.3, Task Switching: 
> "The new task begins executing at the privilege level specified in the CPL field of the CS register, which is loaded from the TSS.”
> As a result, this condition can never occur during task-switch.
> 
> Do I miss anything?

No, you're right.

Paolo

  reply	other threads:[~2014-08-17 21:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13 17:14 Regression problem with commit 5045b46803 Nadav Amit
2014-08-17  6:17 ` Paolo Bonzini
2014-08-17  6:23   ` Nadav Amit
2014-08-17  6:28     ` Paolo Bonzini
2014-08-17  7:19       ` Nadav Amit
2014-08-17  9:35         ` Paolo Bonzini
2014-08-17 19:32           ` [PATCH] KVM: x86: Revert "check CS.DPL against RPL during task switch" Nadav Amit
2014-08-17 19:34             ` [PATCH kvm-unit-tests] x86: Test task-switch with cs.rpl != cs.dpl Nadav Amit
2014-08-19 10:27               ` Paolo Bonzini
2014-08-19 13:04                 ` [PATCH kvm-unit-tests v2] " Nadav Amit
2014-08-19 13:28                   ` Paolo Bonzini
2014-08-19 13:34                     ` Nadav Amit
2014-08-19 13:37                       ` Paolo Bonzini
2014-08-17 21:09             ` [PATCH] KVM: x86: Revert "check CS.DPL against RPL during task switch" Paolo Bonzini
2014-08-17 21:13               ` Paolo Bonzini
2014-08-17 21:33                 ` Nadav Amit
2014-08-17 21:52                   ` Paolo Bonzini [this message]
2014-08-17 21:39               ` Nadav Amit
2014-08-17 21:52                 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F12429.4080103@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=nadav.amit@gmail.com \
    --cc=namit@cs.technion.ac.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.