Re: [RFC][v3][PATCH 3/6] tools:firmware:hvmloader: reserve RMRR mappings in e820

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 18/08/14 08:51, Chen, Tiejun wrote:
> On 2014/8/15 17:58, Andrew Cooper wrote:
>> On 15/08/14 09:27, Tiejun Chen wrote:
>>> We need to reserve all RMRR mappings in e820 to avoid any
>>> potential guest memory conflict.
>>>
>>> Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
>>> ---
>>>   tools/firmware/hvmloader/e820.c | 94
>>> +++++++++++++++++++++++++++++++++++++++++
>>>   tools/firmware/hvmloader/e820.h |  6 +++
>>>   tools/firmware/hvmloader/util.c | 16 +++++++
>>>   tools/firmware/hvmloader/util.h |  2 +
>>>   4 files changed, 118 insertions(+)
>>>
>>> diff --git a/tools/firmware/hvmloader/e820.c
>>> b/tools/firmware/hvmloader/e820.c
>>> index 2e05e93..7f54eab 100644
>>> --- a/tools/firmware/hvmloader/e820.c
>>> +++ b/tools/firmware/hvmloader/e820.c
>>> @@ -68,12 +68,89 @@ void dump_e820_table(struct e820entry *e820,
>>> unsigned int nr)
>>>       }
>>>   }
>>
>> Please apply Xen coding style to all of this file - there are a lot of
>> errors.
>
> I asked previously what Xen coding style is, and I always try to
> follow some existing code but seems its not enough. Here I still can't
> find out what you're pointing, so please tell me exactly what I should
> change exactly.
>
> And why don't you guy generate a checkpatch.pl file?

Xen coding style can be found in the document CODING_STYLE in the source
root.

There have been various attempts at a checkpatch.pl, but we suffer from
inheriting different coding styles from different sources.  Even in Xen,
we mix between Xen and Linux.

~Andrew