From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJLnc-0005eI-Ev for qemu-devel@nongnu.org; Mon, 18 Aug 2014 08:12:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJLnW-0000vk-9w for qemu-devel@nongnu.org; Mon, 18 Aug 2014 08:12:32 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:63744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJLnV-0000qR-Gb for qemu-devel@nongnu.org; Mon, 18 Aug 2014 08:12:26 -0400 Message-ID: <53F1ED7A.5060900@huawei.com> Date: Mon, 18 Aug 2014 20:11:38 +0800 From: "Zhangjie (HZ)" MIME-Version: 1.0 References: <1408355491-42089-1-git-send-email-jasowang@redhat.com> In-Reply-To: <1408355491-42089-1-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , mst@redhat.com, qemu-devel@nongnu.org On 2014/8/18 17:51, Jason Wang wrote: > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > support changed the order of stopping the device. Previously > vhost_dev_stop would disable backend and only afterwards, unset guest > notifiers. We now unset guest notifiers while vhost is still > active. This can lose interrupts causing guest networking to fail. > > Additionally, remove the hdev->started assert in vhost.c since we may > want to start the guest notifiers before vhost starts and stop the > guest notifiers after vhost is stopped. > > In particular, this has been observed during migration. > Thanks! I will have a test about your patch today! :-) -- Best Wishes! Zhang Jie