From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Tang Chen <tangchen@cn.fujitsu.com>
Cc: peter.crosthwaite@xilinx.com, ehabkost@redhat.com,
hutao@cn.fujitsu.com, qemu-devel@nongnu.org,
isimatu.yasuaki@jp.fujitsu.com, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.
Date: Mon, 18 Aug 2014 15:58:33 +0200 [thread overview]
Message-ID: <53F20689.3000207@redhat.com> (raw)
In-Reply-To: <20140818135602.GC28795@redhat.com>
Il 18/08/2014 15:56, Michael S. Tsirkin ha scritto:
> > +/* Initialize PCDIMMDevice->node to -1 so that even if user doesn't specify
> > + * any numa option, PCDIMMDevice->node won't be 0, which indicates node0.
> > + * In this case, SRAT won't be created, and guest kernel will fake a node.
> > + */
>
> I think you simply mean
> /* default value for PCDIMMDevice->node (unless specified by user) */
>
> > +#define NO_NODE_ID -1
I think a comment about the SRAT would be useful.
Paolo
next prev parent reply other threads:[~2014-08-18 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 12:12 [Qemu-devel] [PATCH 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1 Tang Chen
2014-08-18 13:56 ` Michael S. Tsirkin
2014-08-18 13:58 ` Paolo Bonzini [this message]
2014-08-18 20:04 ` Michael S. Tsirkin
2014-08-19 1:47 ` tangchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F20689.3000207@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=mst@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.