From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJQce-0002De-C5 for qemu-devel@nongnu.org; Mon, 18 Aug 2014 13:21:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJQcW-00009r-OM for qemu-devel@nongnu.org; Mon, 18 Aug 2014 13:21:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45772 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJQcW-00009k-I6 for qemu-devel@nongnu.org; Mon, 18 Aug 2014 13:21:24 -0400 Message-ID: <53F23613.9090107@suse.de> Date: Mon, 18 Aug 2014 19:21:23 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <874mxs32vv.fsf@blackfin.pond.sub.org> <20140804114500.GP18947@grmbl.mre> In-Reply-To: <20140804114500.GP18947@grmbl.mre> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-serial: create a linked list of all active devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah , Markus Armbruster Cc: Amos Kong , qemu list Am 04.08.2014 13:45, schrieb Amit Shah: > On (Mon) 04 Aug 2014 [13:33:56], Markus Armbruster wrote: >> Amit Shah writes: >> >>> To ensure two virtserialports don't get added to the system with the >>> same 'name' parameter, we need to access all the ports on all the >>> devices added, and compare the names. >>> >>> We currently don't have a list of all VirtIOSerial devices added to t= he >>> system. This commit adds a simple linked list in which devices are p= ut >>> when they're initialized, and removed when they go away. [...] >> Patch looks simple & safe to me, but I can't help to wonder whether wa= nt >> (or already have?) more generic infrastructure offering "for all devic= es >> of a certain kind" functionality, which is what 2/2 needs. Andreas? >=20 > Yea; I didn't find any, but if there's already something it can be put > to good use here. If you're looking for devices of the same QOM type, that can be done through some QOM path syntax that Paolo introduced. Someone used it in a recent iommu series. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg