All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] bandwidthd: incorporate fixes for autobuilders
Date: Mon, 18 Aug 2014 20:05:06 +0200	[thread overview]
Message-ID: <53F24052.8050601@openwide.fr> (raw)
In-Reply-To: <53F23A6E.3060807@openwide.fr>

Hi Nathaniel,

> 
> I think bandwithd depends on BR2_TOOLCHAIN_HAS_THREADS due to a reverse
> dependency on libusb.
> 
Please forget that. libusb is an optional dependency of libpcap.

I have disabled libusb and now the build error out:

checking for libusb_init in -lusb-1.0... no
configure: error:

libusb and libpthread need to be handled as optional dependencies in bandwidthd.

-pthread need to be added only if the libusb (which depends on
BR2_TOOLCHAIN_HAS_THREADS) is detected

So add BANDWIDTHD_CONF_ENV = LIBS="-pthread" in bandwidthd.mk is not a good idea...

Best regards,
Romain

      reply	other threads:[~2014-08-18 18:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-15  0:27 [Buildroot] [PATCH v2] bandwidthd: incorporate fixes for autobuilders Nathaniel Roach
2014-08-15  9:06 ` Peter Korsgaard
2014-08-18 13:44 ` Romain Naour
2014-08-18 14:40   ` Nathaniel Roach
2014-08-18 15:01   ` Nathaniel Roach
2014-08-18 17:39     ` Romain Naour
2014-08-18 18:05       ` Romain Naour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F24052.8050601@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.