All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Zhen <zhenzhang.zhang@huawei.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Dave Hansen <dave.hansen@intel.com>,
	toshi.kani@hp.com, isimatu.yasuaki@jp.fujitsu.com,
	n-horiguchi@ah.jp.nec.com, wangnan0@huawei.com,
	linux-kernel@vger.kernel.org, Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH v2] memory-hotplug: add sysfs zones_online_to attribute
Date: Tue, 19 Aug 2014 09:43:44 +0800	[thread overview]
Message-ID: <53F2ABD0.1010706@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1408181447260.4796@chino.kir.corp.google.com>

On 2014/8/19 5:48, David Rientjes wrote:
> On Wed, 13 Aug 2014, Zhang Zhen wrote:
> 
>> Currently memory-hotplug has two limits:
>> 1. If the memory block is in ZONE_NORMAL, you can change it to
>> ZONE_MOVABLE, but this memory block must be adjacent to ZONE_MOVABLE.
>> 2. If the memory block is in ZONE_MOVABLE, you can change it to
>> ZONE_NORMAL, but this memory block must be adjacent to ZONE_NORMAL.
>>
>> With this patch, we can easy to know a memory block can be onlined to
>> which zone, and don't need to know the above two limits.
>>
>> Updated the related Documentation.
>>
>> Change v1 -> v2:
>> - optimize the implementation following Dave Hansen's suggestion
>>
>> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
> 
> linux-next build failure:
> 
> drivers/built-in.o: In function `show_zones_online_to':
> memory.c:(.text+0x13ee09): undefined reference to `test_pages_in_a_zone'
> 
The function implementation in mm/memory_hotplug.c is only built if
CONFIG_MEMORY_HOTREMOVE is enabled.

A fix has been proposed.
http://ozlabs.org/~akpm/mmots/broken-out/memory-hotplug-add-sysfs-zones_online_to-attribute-fix-2.patch

Thanks!
> 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Zhang Zhen <zhenzhang.zhang@huawei.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Dave Hansen <dave.hansen@intel.com>, <toshi.kani@hp.com>,
	<isimatu.yasuaki@jp.fujitsu.com>, <n-horiguchi@ah.jp.nec.com>,
	<wangnan0@huawei.com>, <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH v2] memory-hotplug: add sysfs zones_online_to attribute
Date: Tue, 19 Aug 2014 09:43:44 +0800	[thread overview]
Message-ID: <53F2ABD0.1010706@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1408181447260.4796@chino.kir.corp.google.com>

On 2014/8/19 5:48, David Rientjes wrote:
> On Wed, 13 Aug 2014, Zhang Zhen wrote:
> 
>> Currently memory-hotplug has two limits:
>> 1. If the memory block is in ZONE_NORMAL, you can change it to
>> ZONE_MOVABLE, but this memory block must be adjacent to ZONE_MOVABLE.
>> 2. If the memory block is in ZONE_MOVABLE, you can change it to
>> ZONE_NORMAL, but this memory block must be adjacent to ZONE_NORMAL.
>>
>> With this patch, we can easy to know a memory block can be onlined to
>> which zone, and don't need to know the above two limits.
>>
>> Updated the related Documentation.
>>
>> Change v1 -> v2:
>> - optimize the implementation following Dave Hansen's suggestion
>>
>> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
> 
> linux-next build failure:
> 
> drivers/built-in.o: In function `show_zones_online_to':
> memory.c:(.text+0x13ee09): undefined reference to `test_pages_in_a_zone'
> 
The function implementation in mm/memory_hotplug.c is only built if
CONFIG_MEMORY_HOTREMOVE is enabled.

A fix has been proposed.
http://ozlabs.org/~akpm/mmots/broken-out/memory-hotplug-add-sysfs-zones_online_to-attribute-fix-2.patch

Thanks!
> 



  reply	other threads:[~2014-08-19  1:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1407902811-4873-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-08-13  4:10 ` [PATCH v2] memory-hotplug: add sysfs zones_online_to attribute Zhang Zhen
2014-08-13  4:10   ` Zhang Zhen
2014-08-15 21:37   ` Toshi Kani
2014-08-15 21:37     ` Toshi Kani
2014-08-18  3:25     ` Zhang Zhen
2014-08-18  3:25       ` Zhang Zhen
2014-08-18  6:20       ` Yasuaki Ishimatsu
2014-08-18  6:20         ` Yasuaki Ishimatsu
2014-08-22 22:16       ` Andrew Morton
2014-08-22 22:16         ` Andrew Morton
2014-08-22 22:21         ` Dave Hansen
2014-08-22 22:21           ` Dave Hansen
2014-08-25  1:55         ` Zhang Zhen
2014-08-25  1:55           ` Zhang Zhen
2014-08-25 13:58         ` Toshi Kani
2014-08-25 13:58           ` Toshi Kani
2014-08-18  6:11   ` Yasuaki Ishimatsu
2014-08-18  6:11     ` Yasuaki Ishimatsu
2014-08-19  7:35     ` Zhang Zhen
2014-08-19  7:35       ` Zhang Zhen
2014-08-19 10:42       ` Yasuaki Ishimatsu
2014-08-19 10:42         ` Yasuaki Ishimatsu
2014-08-18 21:48   ` David Rientjes
2014-08-18 21:48     ` David Rientjes
2014-08-19  1:43     ` Zhang Zhen [this message]
2014-08-19  1:43       ` Zhang Zhen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F2ABD0.1010706@huawei.com \
    --to=zhenzhang.zhang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=rientjes@google.com \
    --cc=toshi.kani@hp.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.