From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pramod Gurav <pramod.gurav@smartplayin.com>
Subject: Re: [PATCH v3 4/8] qcom: spm-devices: Add SPM device manager for
 the SoC
Date: Tue, 19 Aug 2014 14:59:56 +0530
Message-ID: <53F31914.9040804@smartplayin.com>
References: <1408400614-45419-1-git-send-email-lina.iyer@linaro.org> <1408400614-45419-5-git-send-email-lina.iyer@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from smtp86.ord1c.emailsrvr.com ([108.166.43.86]:50143 "EHLO
	smtp86.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750768AbaHSJ00 (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Tue, 19 Aug 2014 05:26:26 -0400
In-Reply-To: <1408400614-45419-5-git-send-email-lina.iyer@linaro.org>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Lina Iyer <lina.iyer@linaro.org>
Cc: daniel.lezcano@linaro.org, khilman@linaro.org, sboyd@codeaurora.org, davidb@codeaurora.org, galak@codeaurora.org, linux-arm-msm@vger.kernel.org, lorenzo.pieralisi@arm.com, msivasub@codeauorora.org, Praveen Chidamabram <pchidamb@codeaurora.org>, Murali Nalajala <mnalajal@codeaurora.org>

Hi Lina,

On Tuesday 19 August 2014 03:53 AM, Lina Iyer wrote:
> +
> +config QCOM_PM
> +	tristate "Qualcomm Power Management"
This does not compile as a module. making CONFIG_QCOM_PM=3Dm causing
redefinition of function 'msm_spm_set_low_power_mode' in header.

drivers/soc/qcom/spm-devices.c:48:5: error: redefinition of
=91msm_spm_set_low_power_mode=92
In file included from drivers/soc/qcom/spm-devices.c:25:0:
include/soc/qcom/spm.h:30:19: note: previous definition of
=91msm_spm_set_low_power_mode=92 was here


> +	depends on PM && ARCH_QCOM && OF
> +	help
> +	  QCOM Platform specific power driver to manage cores and L2 low po=
wer
> +	  modes. It interface with various system drivers to put the cores =
in
> +	  low power modes.
> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
> index 20b329f..9457b2a 100644
> --- a/drivers/soc/qcom/Makefile
> +++ b/drivers/soc/qcom/Makefile
> @@ -1,4 +1,4 @@
>  obj-$(CONFIG_QCOM_GSBI)	+=3D	qcom_gsbi.o
> -obj-$(CONFIG_QCOM_PM)	+=3D	spm.o
> +obj-$(CONFIG_QCOM_PM)	+=3D	spm.o spm-devices.o
>  CFLAGS_scm.o :=3D$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=3D=
1)
>  obj-$(CONFIG_QCOM_SCM) +=3D scm.o scm-boot.o