All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] arm: debug: import debug files from Linux 3.16
Date: Tue, 19 Aug 2014 13:01:21 +0200	[thread overview]
Message-ID: <53F32E81.1030802@denx.de> (raw)
In-Reply-To: <1408256217-3706-4-git-send-email-yamada.m@jp.panasonic.com>

Hi Masahiro!

On 17.08.2014 08:16, Masahiro Yamada wrote:
> U-Boot does not have arch/arm/kernel, include/uapi directories,
> This commit copies files as follows:
>
>    Location in Linux               -> Location in U-Boot
>
>    arch/arm/kernel/debug.S         -> arch/arm/lib/debug.S
>    arch/arm/include/debug/8250.S   -> arch/arm/include/debug/8250.S
>    include/uapi/linux/serial_reg.h -> include/linux/serial_reg.h
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Nice! I have quite often found myself also in the need of an very early 
serial debug output functionality. Thanks for this series. One comment 
below:

> ---
>
>   arch/arm/include/debug/8250.S |  54 ++++++
>   arch/arm/lib/debug.S          | 138 +++++++++++++++
>   include/linux/serial_reg.h    | 389 ++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 581 insertions(+)
>   create mode 100644 arch/arm/include/debug/8250.S
>   create mode 100644 arch/arm/lib/debug.S
>   create mode 100644 include/linux/serial_reg.h
>
> diff --git a/arch/arm/include/debug/8250.S b/arch/arm/include/debug/8250.S
> new file mode 100644
> index 0000000..7a2baf9
> --- /dev/null
> +++ b/arch/arm/include/debug/8250.S
> @@ -0,0 +1,54 @@
> +/*
> + * arch/arm/include/debug/8250.S
> + *
> + *  Copyright (C) 1994-2013 Russell King
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.

Please use SPDX license identifiers instead. Please fix this globally.

Thanks,
Stefan

  reply	other threads:[~2014-08-19 11:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-17  6:16 [U-Boot] [PATCH 0/4] Introduce low-level debug for ARM architecture Masahiro Yamada
2014-08-17  6:16 ` [U-Boot] [PATCH 1/4] vexpress64: kconfig: consolidate CONFIG_TARGET_VEXPRESS_AEMV8A_SEMI Masahiro Yamada
2014-08-25 18:01   ` Steve Rae
2014-08-17  6:16 ` [U-Boot] [PATCH 2/4] kconfig: armv8: move CONFIG_ARM64 to Kconfig Masahiro Yamada
2014-08-17  6:16 ` [U-Boot] [PATCH 3/4] arm: debug: import debug files from Linux 3.16 Masahiro Yamada
2014-08-19 11:01   ` Stefan Roese [this message]
2014-08-20 13:53     ` Masahiro YAMADA
2014-08-25  9:03   ` Przemyslaw Marczak
2014-08-26  3:26     ` Masahiro Yamada
2014-08-27 14:27       ` Przemyslaw Marczak
2014-08-17  6:16 ` [U-Boot] [PATCH 4/4] arm: debug: add Kconfig entries for lowlevel debug Masahiro Yamada
2014-08-19  2:14 ` [U-Boot] [PATCH 0/4] Introduce low-level debug for ARM architecture York Sun
2014-08-19  7:45   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F32E81.1030802@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.