From: Jiri Slaby <jslaby@suse.cz>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH] drivers/tty/nozomi.c: Use 'nozomi_setup_memory' instead of 'setup_memory'
Date: Tue, 19 Aug 2014 13:34:22 +0200 [thread overview]
Message-ID: <53F3363E.3030601@suse.cz> (raw)
In-Reply-To: <53E4F332.2080407@gmail.com>
On 08/08/2014, 05:56 PM, Chen Gang wrote:
> Several architectures (e.g. microblaze, um, and score) have already have
> extern 'setup_memory', so need use 'nozomi_setup_memory' instead of, or
> will cause compiling issue.
>
> The related error (with allmodconfig for microblaze):
>
> CC [M] drivers/tty/nozomi.o
> drivers/tty/nozomi.c:526:13: error: conflicting types for 'setup_memory'
> static void setup_memory(struct nozomi *dc)
> ^
> In file included from include/linux/mm.h:51:0,
> from ./arch/microblaze/include/asm/io.h:17,
> from include/linux/io.h:22,
> from include/linux/pci.h:31,
> from drivers/tty/nozomi.c:46:
> ./arch/microblaze/include/asm/pgtable.h:569:6: note: previous declaration of 'setup_memory' was here
> void setup_memory(void);
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Oh, sure. Thanks.
Acked-by: Jiri Slaby <jslaby@suse.cz>
--
js
suse labs
prev parent reply other threads:[~2014-08-19 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 15:56 [PATCH] drivers/tty/nozomi.c: Use 'nozomi_setup_memory' instead of 'setup_memory' Chen Gang
2014-08-19 11:34 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F3363E.3030601@suse.cz \
--to=jslaby@suse.cz \
--cc=gang.chen.5i5j@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.