From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem Date: Tue, 19 Aug 2014 14:01:32 +0200 Message-ID: <53F33C9C.1080601@samsung.com> References: <1407235677-26324-1-git-send-email-m.szyprowski@samsung.com> <20140818233201.GL9809@8bytes.org> <53F2E9AD.9030308@samsung.com> <53F3375E.6030402@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <53F3375E.6030402-l3A5Bk7waGM@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Inki Dae Cc: Thierry Reding , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shaik Ameer Basha , Arnd Bergmann , Rob Herring , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tomasz Figa , linaro-mm-sig-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Kukjin Kim , Laurent Pinchart , Sylwester Nawrocki , Kyungmin Park , Cho KyongHo , Ajay Kumar , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org SGVsbG8sCgpPbiAyMDE0LTA4LTE5IDEzOjM5LCBBbmRyZWFzIEbDpHJiZXIgd3JvdGU6Cj4gSGkg TWFyZWsgYW5kIElua2ksCj4KPiBBbSAxOS4wOC4yMDE0IDA4OjA3LCBzY2hyaWViIE1hcmVrIFN6 eXByb3dza2k6Cj4+IE9uIDIwMTQtMDgtMTkgMDE6MzIsIEpvZXJnIFJvZWRlbCB3cm90ZToKPj4+ IE9uIFR1ZSwgQXVnIDA1LCAyMDE0IGF0IDEyOjQ3OjI4UE0gKzAyMDAsIE1hcmVrIFN6eXByb3dz a2kgd3JvdGU6Cj4gWy4uLl0KPj4+PiAgICAzMyBmaWxlcyBjaGFuZ2VkLCAxMDE2IGluc2VydGlv bnMoKyksIDM1NiBkZWxldGlvbnMoLSkKPj4+IFRoaXMgdG91Y2hlcyBhIGxvdCBvZiBub24taW9t bXUgc3R1ZmYuIFdoYXQgaXMgeW91ciBzdHJhdGVneSBvbiBnZXR0aW5nCj4+PiB0aGlzIGluLCBk byB5b3UgcGxhbiB0byBnZXQgdGhlIG5vbi1pb21tdSBjaGFuZ2VzIG1lcmdlZCBmaXJzdCBvciBk byB5b3UKPj4+IHdhbnQgdG8gY29sbGVjdCB0aGUgcmVzcGVjdGl2ZSBBY2tzIGFuZCBtZXJnZSB0 aGlzIGFsbCB0aHJvdWdoIG9uZSB0cmVlPwo+PiBUaG9zZSBwYXRjaGVzIGFyZSBwb3N0ZWQgYXMg b25lIHBhdGNoc2V0IG1haW5seSB0byBkZW1vbnN0cmF0ZSBob3cgdG8gZ2V0Cj4+IGV2ZXJ5dGhp bmcgdG8gd29yayB0b2dldGhlci4gSSBhbHNvIHBvc3RlZCB0aGlzIGFzIGEgc2luZ2xlIHBhdGNo IHNlcmllcwo+PiB0byBnZXQgc29tZSBmZWVkYmFjayBmcm9tIG90aGVyIGlvbW11IGRldmVsb3Bl cnMsIGVzcGVjaWFsbHkgYWxsIHRob3NlCj4+IGludm9sdmVkIGluIHRoZSBnZW5lcmljIGlvbW11 IGR0IGJpbmRpbmdzLgo+Pgo+PiBGb3IgbWVyZ2luZywgSSB3aWxsIHNwbGl0IHRoZW0gaW50byBz bWFsbGVyIHNlcmllcyBhbmQgdHJ5IHRvIGdldAo+PiByZXNwZWN0aXZlIGFja3MuCj4gSSdtIHdv cmtpbmcgb24gNTI1MCBiYXNlZCBTcHJpbmcgQ2hyb21lYm9vayBhbmQgbm90aWNlZCB0aGF0IHYz LjE3LXJjMQo+IGdvdCBzb21lIG1vcmUgaW9tbXUgc3VwcG9ydC4gV2l0aCB0aGUgbmV3IENPTkZJ R19EUk1fRVhZTk9TX0lPTU1VPXkgbXkKPiBtYWNoaW5lIHN0b3BzIGJvb3RpbmcuIFNvIEknbSB3 b25kZXJpbmcsIGlzIGFueSBvZiB0aGlzIGEgZml4IGZvciAzLjE3LAo+IG9yIGlzIGFsbCBvZiB0 aGlzICJ1bnJlbGF0ZWQiIC1uZXh0IG1hdGVyaWFsPwoKVGhpcyBpcyBwcm9iYWJseSBhIHNpZGUg ZWZmZWN0IG9mIHBhdGNoIAozMTcwNDQ3YzFmMjY0ZDUxYjhkMWYzODk4YmYyNTg4NTg4YTY0ZmRj CigiaW9tbXUvZXh5bm9zOiBTZWxlY3QgQVJNX0RNQV9VU0VfSU9NTVUiKS4gSXQgYWRkZWQgc2Vs ZWN0aW9uIG9mIApBUk1fRE1BX1VTRV9JT01NVQpzeW1ib2wsIG9uIHdoaWNoIElPTU1VIHN1cHBv cnQgaW4gRXh5bm9zIERSTSBzdWJzeXN0ZW0gZGVwZW5kcy4gSG93ZXZlciAKc2VsZWN0aW5nCnRo aXMgc3ltYm9sIGlzIGFsbCB0aGF0IHRoaXMgcGF0Y2ggZG9lcywgd2l0aG91dCBwcm92aWRpbmcg YW55IGNvZGUgY29kZSAKd2hpY2gKaW1wbGVtZW50cyByZWFsIHN1cHBvcnQgZm9yIEFSTSBETUEg SU9NTVUgaW50ZWdyYXRpb24sIHdoaWNoIGlzIG5lZWRlZCAKYnkgRXh5bm9zCkRSTSBkcml2ZXIu IFBsZWFzZSBkaXNhYmxlIENPTkZJR19EUk1fRVhZTk9TX0lPTU1VIGluIGtlcm5lbCAuY29uZmln IGFuZCAKeW91cgpzeXN0ZW0gc2hvdWxkIGJlIGJvb3RhYmxlIGFnYWluLgoKPiBBbHNvLCBhcmUg eW91IG9yIHNvbWVvbmUKPiB3b3JraW5nIG9uIHRoZSByZXNwZWN0aXZlIERUIGNoYW5nZXMgZm9y IEV4eW5vczU/CgpJIGNhbiBwcmVwYXJlIERUIGNoYW5nZXMgZm9yIEV4eW5vczUgYXMgd2VsbCwg YnV0IGZpcnN0IEkgd2FudGVkIHRvIApjbGFyaWZ5IGlmCmV2ZXJ5b25lIGludm9sdmVkIGluIGdl bmVyaWMgSU9NTVUgYmluZGluZ3MgYW5kIEV4eW5vcyBJT01NVSBkcml2ZXIgCmFncmVlcyBvbiBt eQpwcm9wb3NhbC4KCkJlc3QgcmVnYXJkcwotLSAKTWFyZWsgU3p5cHJvd3NraSwgUGhEClNhbXN1 bmcgUiZEIEluc3RpdHV0ZSBQb2xhbmQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0cy5saW51eC1mb3Vu ZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0 aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 From: m.szyprowski@samsung.com (Marek Szyprowski) Date: Tue, 19 Aug 2014 14:01:32 +0200 Subject: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem In-Reply-To: <53F3375E.6030402@suse.de> References: <1407235677-26324-1-git-send-email-m.szyprowski@samsung.com> <20140818233201.GL9809@8bytes.org> <53F2E9AD.9030308@samsung.com> <53F3375E.6030402@suse.de> Message-ID: <53F33C9C.1080601@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On 2014-08-19 13:39, Andreas F?rber wrote: > Hi Marek and Inki, > > Am 19.08.2014 08:07, schrieb Marek Szyprowski: >> On 2014-08-19 01:32, Joerg Roedel wrote: >>> On Tue, Aug 05, 2014 at 12:47:28PM +0200, Marek Szyprowski wrote: > [...] >>>> 33 files changed, 1016 insertions(+), 356 deletions(-) >>> This touches a lot of non-iommu stuff. What is your strategy on getting >>> this in, do you plan to get the non-iommu changes merged first or do you >>> want to collect the respective Acks and merge this all through one tree? >> Those patches are posted as one patchset mainly to demonstrate how to get >> everything to work together. I also posted this as a single patch series >> to get some feedback from other iommu developers, especially all those >> involved in the generic iommu dt bindings. >> >> For merging, I will split them into smaller series and try to get >> respective acks. > I'm working on 5250 based Spring Chromebook and noticed that v3.17-rc1 > got some more iommu support. With the new CONFIG_DRM_EXYNOS_IOMMU=y my > machine stops booting. So I'm wondering, is any of this a fix for 3.17, > or is all of this "unrelated" -next material? This is probably a side effect of patch 3170447c1f264d51b8d1f3898bf2588588a64fdc ("iommu/exynos: Select ARM_DMA_USE_IOMMU"). It added selection of ARM_DMA_USE_IOMMU symbol, on which IOMMU support in Exynos DRM subsystem depends. However selecting this symbol is all that this patch does, without providing any code code which implements real support for ARM DMA IOMMU integration, which is needed by Exynos DRM driver. Please disable CONFIG_DRM_EXYNOS_IOMMU in kernel .config and your system should be bootable again. > Also, are you or someone > working on the respective DT changes for Exynos5? I can prepare DT changes for Exynos5 as well, but first I wanted to clarify if everyone involved in generic IOMMU bindings and Exynos IOMMU driver agrees on my proposal. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbaHSMBj (ORCPT ); Tue, 19 Aug 2014 08:01:39 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:50558 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbaHSMBh (ORCPT ); Tue, 19 Aug 2014 08:01:37 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8; format=flowed X-AuditID: cbfec7f5-b7f776d000003e54-13-53f33c9ee951 Content-transfer-encoding: 8BIT Message-id: <53F33C9C.1080601@samsung.com> Date: Tue, 19 Aug 2014 14:01:32 +0200 From: Marek Szyprowski User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.0 To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Inki Dae Cc: Joerg Roedel , iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Arnd Bergmann , Shaik Ameer Basha , Cho KyongHo , Thierry Reding , Olof Johansson , Laurent Pinchart , Rob Herring , Greg Kroah-Hartman , "Rafael J. Wysocki" , Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Kyungmin Park , Ajay Kumar Subject: Re: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem References: <1407235677-26324-1-git-send-email-m.szyprowski@samsung.com> <20140818233201.GL9809@8bytes.org> <53F2E9AD.9030308@samsung.com> <53F3375E.6030402@suse.de> In-reply-to: <53F3375E.6030402@suse.de> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t/xq7rzbD4HGzxqlbJo3lRsceD9QRaL v5OOsVs0L17PZjHp/gQWiwX7rS06Z29gt+hdcJXN4mzTG3aLzolL2C2+XHnIZLHp8TVWi8u7 5rBZzDi/j8ni1PXPbBb/eg8yWpw5fYnV4v+eHewWh9+0s1ocebib3WLVrj+MFrd/8zmIeTw5 OI/J4/evSYweO2fdZfeY3TGT1WPTqk42j/1z17B7bF5S73H732Nmj8k3ljN6XDnRxOrR2/yO zWPL1XYWj74tqxg9Np+u9vi8SS6AP4rLJiU1J7MstUjfLoEr4+HbT+wFMwUqFlx9xNjA2Mbb xcjJISFgItG3YQcrhC0mceHeerYuRi4OIYGljBJnFiwDS/AKCEr8mHyPpYuRg4NZQF7iyKVs kDCzgJnEl5eHWSHqPzFKvD6ymBGiXkvi0fM3YDaLgKpE+76tLCA2m4ChRNfbLjaQOaICURLH vuaBhEWAzI89M1ggZk5hk5jSZQViCwskSPz708ECMX8lo8ScRa/BZnIKqEu8mXyOZQKjwCwk 581COG8WkvMWMDKvYhRNLU0uKE5KzzXSK07MLS7NS9dLzs/dxAiJ6a87GJceszrEKMDBqMTD q/DlY7AQa2JZcWXuIUYJDmYlEd4O6c/BQrwpiZVVqUX58UWlOanFhxiZODilGhjnLhRVU9n1 ZPHrw7tOT9CaeND3qvHt5Hsvfp7VF1KJ4S/K8/q9TkSSZcmvNN3LIV7VzpmGPXZ+a5N8uQTW MyurSU0Olvt0t3D7dD3ddws/Hjz2f+I0o82eQSfCbqne7+b8xtnlNVH4SqLSsu6Ym6f3z7G4 cefZSbU/YTt6XGOjl/Z7Z08Lma6vxFKckWioxVxUnAgAshKhaMcCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2014-08-19 13:39, Andreas Färber wrote: > Hi Marek and Inki, > > Am 19.08.2014 08:07, schrieb Marek Szyprowski: >> On 2014-08-19 01:32, Joerg Roedel wrote: >>> On Tue, Aug 05, 2014 at 12:47:28PM +0200, Marek Szyprowski wrote: > [...] >>>> 33 files changed, 1016 insertions(+), 356 deletions(-) >>> This touches a lot of non-iommu stuff. What is your strategy on getting >>> this in, do you plan to get the non-iommu changes merged first or do you >>> want to collect the respective Acks and merge this all through one tree? >> Those patches are posted as one patchset mainly to demonstrate how to get >> everything to work together. I also posted this as a single patch series >> to get some feedback from other iommu developers, especially all those >> involved in the generic iommu dt bindings. >> >> For merging, I will split them into smaller series and try to get >> respective acks. > I'm working on 5250 based Spring Chromebook and noticed that v3.17-rc1 > got some more iommu support. With the new CONFIG_DRM_EXYNOS_IOMMU=y my > machine stops booting. So I'm wondering, is any of this a fix for 3.17, > or is all of this "unrelated" -next material? This is probably a side effect of patch 3170447c1f264d51b8d1f3898bf2588588a64fdc ("iommu/exynos: Select ARM_DMA_USE_IOMMU"). It added selection of ARM_DMA_USE_IOMMU symbol, on which IOMMU support in Exynos DRM subsystem depends. However selecting this symbol is all that this patch does, without providing any code code which implements real support for ARM DMA IOMMU integration, which is needed by Exynos DRM driver. Please disable CONFIG_DRM_EXYNOS_IOMMU in kernel .config and your system should be bootable again. > Also, are you or someone > working on the respective DT changes for Exynos5? I can prepare DT changes for Exynos5 as well, but first I wanted to clarify if everyone involved in generic IOMMU bindings and Exynos IOMMU driver agrees on my proposal. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland