From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem Date: Tue, 19 Aug 2014 14:30:59 +0200 Message-ID: <53F34383.30100@suse.de> References: <1407235677-26324-1-git-send-email-m.szyprowski@samsung.com> <20140818233201.GL9809@8bytes.org> <53F2E9AD.9030308@samsung.com> <53F3375E.6030402@suse.de> <53F33C9C.1080601@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <53F33C9C.1080601@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Marek Szyprowski , Inki Dae Cc: Joerg Roedel , iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Arnd Bergmann , Shaik Ameer Basha , Cho KyongHo , Thierry Reding , Olof Johansson , Laurent Pinchart , Rob Herring , Greg Kroah-Hartman , "Rafael J. Wysocki" , Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Kyungmin Park , Ajay Kumar List-Id: iommu@lists.linux-foundation.org Hi, Am 19.08.2014 14:01, schrieb Marek Szyprowski: > On 2014-08-19 13:39, Andreas F=C3=A4rber wrote: >> I'm working on 5250 based Spring Chromebook and noticed that v3.17-r= c1 >> got some more iommu support. With the new CONFIG_DRM_EXYNOS_IOMMU=3D= y my >> machine stops booting. So I'm wondering, is any of this a fix for 3.= 17, >> or is all of this "unrelated" -next material? >=20 > This is probably a side effect of patch > 3170447c1f264d51b8d1f3898bf2588588a64fdc > ("iommu/exynos: Select ARM_DMA_USE_IOMMU"). It added selection of > ARM_DMA_USE_IOMMU > symbol, on which IOMMU support in Exynos DRM subsystem depends. Howev= er > selecting > this symbol is all that this patch does, without providing any code c= ode > which > implements real support for ARM DMA IOMMU integration, which is neede= d > by Exynos > DRM driver. Please disable CONFIG_DRM_EXYNOS_IOMMU in kernel .config = and > your > system should be bootable again. Yes, that's what my report implied. :) I'm bringing this up for -rc2 though: It sounds as if that option shoul= d remain unavailable until the required code is in? Thanks. >> Also, are you or someone >> working on the respective DT changes for Exynos5? >=20 > I can prepare DT changes for Exynos5 as well, but first I wanted to > clarify if > everyone involved in generic IOMMU bindings and Exynos IOMMU driver > agrees on my > proposal. Sure. I'm updating my old spring-bridge.v6 branch [1] to 3.17-rc1 [2], which involves three drm bridge patches rebased onto the new drm panel prepare/unprepare infrastructure plus two LVDS DT patches in addition t= o the IOMMU patches. That old branch included DT changes for 5250 in "ARM= : dts: add System MMU nodes of Exynos SoCs", but that'll probably need updating for the new bindings. Regards, Andreas [1] https://github.com/afaerber/linux/commits/spring-bridge.v6 [2] https://github.com/afaerber/linux/commits/spring-next --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg From mboxrd@z Thu Jan 1 00:00:00 1970 From: afaerber@suse.de (=?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?=) Date: Tue, 19 Aug 2014 14:30:59 +0200 Subject: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem In-Reply-To: <53F33C9C.1080601@samsung.com> References: <1407235677-26324-1-git-send-email-m.szyprowski@samsung.com> <20140818233201.GL9809@8bytes.org> <53F2E9AD.9030308@samsung.com> <53F3375E.6030402@suse.de> <53F33C9C.1080601@samsung.com> Message-ID: <53F34383.30100@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Am 19.08.2014 14:01, schrieb Marek Szyprowski: > On 2014-08-19 13:39, Andreas F?rber wrote: >> I'm working on 5250 based Spring Chromebook and noticed that v3.17-rc1 >> got some more iommu support. With the new CONFIG_DRM_EXYNOS_IOMMU=y my >> machine stops booting. So I'm wondering, is any of this a fix for 3.17, >> or is all of this "unrelated" -next material? > > This is probably a side effect of patch > 3170447c1f264d51b8d1f3898bf2588588a64fdc > ("iommu/exynos: Select ARM_DMA_USE_IOMMU"). It added selection of > ARM_DMA_USE_IOMMU > symbol, on which IOMMU support in Exynos DRM subsystem depends. However > selecting > this symbol is all that this patch does, without providing any code code > which > implements real support for ARM DMA IOMMU integration, which is needed > by Exynos > DRM driver. Please disable CONFIG_DRM_EXYNOS_IOMMU in kernel .config and > your > system should be bootable again. Yes, that's what my report implied. :) I'm bringing this up for -rc2 though: It sounds as if that option should remain unavailable until the required code is in? Thanks. >> Also, are you or someone >> working on the respective DT changes for Exynos5? > > I can prepare DT changes for Exynos5 as well, but first I wanted to > clarify if > everyone involved in generic IOMMU bindings and Exynos IOMMU driver > agrees on my > proposal. Sure. I'm updating my old spring-bridge.v6 branch [1] to 3.17-rc1 [2], which involves three drm bridge patches rebased onto the new drm panel prepare/unprepare infrastructure plus two LVDS DT patches in addition to the IOMMU patches. That old branch included DT changes for 5250 in "ARM: dts: add System MMU nodes of Exynos SoCs", but that'll probably need updating for the new bindings. Regards, Andreas [1] https://github.com/afaerber/linux/commits/spring-bridge.v6 [2] https://github.com/afaerber/linux/commits/spring-next -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg