From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH kvm-unit-tests 1/2] x86: Use host CPU parameter for apic test Date: Tue, 19 Aug 2014 15:23:43 +0200 Message-ID: <53F34FDF.6020405@redhat.com> References: <1408390933-2876-1-git-send-email-namit@cs.technion.ac.il> <1408391038-2930-1-git-send-email-namit@cs.technion.ac.il> <53F31E09.1060307@redhat.com> <20140819131802.GH3011@thinpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Nadav Amit , gleb@kernel.org, kvm@vger.kernel.org To: Eduardo Habkost Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17694 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbaHSNXw (ORCPT ); Tue, 19 Aug 2014 09:23:52 -0400 In-Reply-To: <20140819131802.GH3011@thinpad.lan.raisama.net> Sender: kvm-owner@vger.kernel.org List-ID: Il 19/08/2014 15:18, Eduardo Habkost ha scritto: > On Tue, Aug 19, 2014 at 11:51:05AM +0200, Paolo Bonzini wrote: >> Il 18/08/2014 21:43, Nadav Amit ha scritto: >>> Currently, the TSC deadline test never runs, since TSC deadline is disabled >>> unless the host cpu parameter is used. This patch changes the apic test to use >>> the qemu host cpu parameter. >> >> Better use >>> Signed-off-by: Nadav Amit >>> --- >>> x86/unittests.cfg | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/x86/unittests.cfg b/x86/unittests.cfg >>> index 6d3e23a..f692b2b 100644 >>> --- a/x86/unittests.cfg >>> +++ b/x86/unittests.cfg >>> @@ -9,7 +9,7 @@ >>> [apic] >>> file = apic.flat >>> smp = 2 >>> -extra_params = -cpu qemu64,+x2apic >>> +extra_params = -cpu host,+x2apic >>> arch = x86_64 >>> >>> [smptest] >>> >> >> Eduardo, I think we should add tsc_deadline to QEMU instead? > > "+tsc-deadline" is supported by QEMU since v1.1.0. Thanks, I applied this: diff --git a/x86/unittests.cfg b/x86/unittests.cfg index 6d3e23a..0123944 100644 --- a/x86/unittests.cfg +++ b/x86/unittests.cfg @@ -9,7 +9,7 @@ [apic] file = apic.flat smp = 2 -extra_params = -cpu qemu64,+x2apic +extra_params = -cpu qemu64,+x2apic,+tsc-deadline arch = x86_64 [smptest] Paolo