From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
gonglei <arei.gonglei@huawei.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
peter.huangpeng@huawei.com,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev: add missing error check
Date: Tue, 19 Aug 2014 16:03:00 +0200 [thread overview]
Message-ID: <53F35914.1030304@redhat.com> (raw)
In-Reply-To: <CAEgOgz6pcr9REr0RBaBDPw9v4C9+1YyE7rHCofmCcVuRXC=80A@mail.gmail.com>
Il 19/08/2014 15:50, Peter Crosthwaite ha scritto:
> So I'm curious to know if and how this manifested for you as a bug?
> Can you reproduce this as a bug somehow even as a memory leak? as the
> only way I can see local_err getting populated is a fail of:
>
> object_property_add_child(container_get(qdev_get_machine(),
> "/unattached"),
> name, obj, &local_err);
>
> Which, if fails indicates something very wrong. Should we promote that
> fail to &error_abort and just drop the local_err logic entirely? I'm
> very interested on your replication conditions on this one.
Yes, I don't think it can happen. The user can only refer to
/machine/peripheral, not /machine/unattached. &error_abort is better.
Paolo
next prev parent reply other threads:[~2014-08-19 14:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 9:41 [Qemu-devel] [PATCH 0/3] Refactor device_set_realized to avoid resource leak arei.gonglei
2014-08-19 9:41 ` [Qemu-devel] [PATCH 1/3] qdev: add missing error check arei.gonglei
2014-08-19 13:50 ` Peter Crosthwaite
2014-08-19 14:03 ` Paolo Bonzini [this message]
2014-08-20 2:29 ` Gonglei (Arei)
2014-08-20 2:27 ` Gonglei (Arei)
2014-08-19 9:41 ` [Qemu-devel] [PATCH 2/3] qdev: Refactor device_set_realized to avoid resource leak arei.gonglei
2014-08-19 13:46 ` Peter Crosthwaite
2014-08-20 2:36 ` Gonglei (Arei)
2014-08-19 9:41 ` [Qemu-devel] [PATCH 3/3] pcie: using error_setg instead of impolite assert arei.gonglei
2014-08-19 13:50 ` Peter Crosthwaite
2014-08-20 2:54 ` Gonglei (Arei)
2014-08-19 21:31 ` Michael S. Tsirkin
2014-08-20 2:50 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F35914.1030304@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=arei.gonglei@huawei.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.