All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/4] qcow2: Allow runtime specification of cache sizes
Date: Tue, 19 Aug 2014 08:18:47 -0600	[thread overview]
Message-ID: <53F35CC7.1040909@redhat.com> (raw)
In-Reply-To: <20140819140049.GG4638@noname.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

On 08/19/2014 08:00 AM, Kevin Wolf wrote:
> Am 18.08.2014 um 22:07 hat Max Reitz geschrieben:
>> Currently, the metadata cache size is only tunable on compile time
>> through macros. However, some users may want to use the minimal cache
>> size (for whatever reason) and others may want to increase the cache
>> size because they have enough memory and want to increase performance.
>>
>> This series adds runtime options for setting the cache size in bytes
>> (which is an easily comprehensible unit) in various ways (by setting
>> each cache explicitly or the total size).
>>
>>
>> This series (patch 2) depends on Markus' series
>> "[PATCH v2 0/4] block: Use g_new() & friends more".
>>
>>
>> v2:
>>  - Patch 2: c->entries may be NULL in the fail path; respect that case
> 
> Thanks, applied all to the block branch (with patch 1 changed as
> commented there).

I'd still like to see the changes to qapi/block-core.json that expose
these for hot-plugging before we call this series finished (I mentioned
that in my review of v1, without realizing that v2 had already been sent).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]

  reply	other threads:[~2014-08-19 14:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18 20:07 [Qemu-devel] [PATCH v2 0/4] qcow2: Allow runtime specification of cache sizes Max Reitz
2014-08-18 20:07 ` [Qemu-devel] [PATCH v2 1/4] qcow2: Constant cache size in bytes Max Reitz
2014-08-19 13:27   ` Kevin Wolf
2014-08-18 20:07 ` [Qemu-devel] [PATCH v2 2/4] qcow2: Use g_try_new0() for cache array Max Reitz
2014-08-18 20:07 ` [Qemu-devel] [PATCH v2 3/4] qcow2: Add runtime options for cache sizes Max Reitz
2014-08-18 20:07 ` [Qemu-devel] [PATCH v2 4/4] iotests: Add test for qcow2's cache options Max Reitz
2014-08-19 14:00 ` [Qemu-devel] [PATCH v2 0/4] qcow2: Allow runtime specification of cache sizes Kevin Wolf
2014-08-19 14:18   ` Eric Blake [this message]
2014-08-19 14:39     ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F35CC7.1040909@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.