All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Álvaro Neira Ayuso" <alvaroneay@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/3] nftables: fix some endian issues
Date: Tue, 19 Aug 2014 19:22:34 +0200	[thread overview]
Message-ID: <53F387DA.90205@gmail.com> (raw)
In-Reply-To: <1408404451-9075-1-git-send-email-kaber@trash.net>

Hello Patrick

El 19/08/14 01:27, Patrick McHardy escribió:
> These patches fix the endian issues Alvaro observed in the bridge table.
>
> The main problem was that the ETH_P_* values are in host byte order, so
> they never matches. This is fixed by simply converting the constants to
> big endian.
>
> Two related problems are that symbol table printing and higher layer
> protocol lookup didn't take endianess into account properly. This is
> fixes by exporting the value in the proper byte order before comparison.
>
> With these patches, everything works as expected:
>
> table bridge filter {
> 	chain input {
> 		 type filter hook input priority -200;
> 		 ip daddr 192.168.1.80 tcp dport ssh counter packets 0 bytes 0
> 		 ether type ip counter packets 128 bytes 36734
> 		 ether type arp counter packets 12 bytes 336
> 	}
> }
>

I have been using the patches and it works perfectly. Thank you very much.

Alvaro
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2014-08-19 17:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18 23:27 [PATCH 0/3] nftables: fix some endian issues Patrick McHardy
2014-08-18 23:27 ` [PATCH 1/3] payload: take endianess into account when updating the payload context Patrick McHardy
2014-08-18 23:27 ` [PATCH 2/3] datatype: take endianess into account in symbolic_constant_print() Patrick McHardy
2014-08-18 23:27 ` [PATCH 3/3] proto: fix byteorder of ETH_P_* values Patrick McHardy
2014-08-19 17:22 ` Álvaro Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F387DA.90205@gmail.com \
    --to=alvaroneay@gmail.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.