From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Longerbeam Subject: Re: [PATCH v2 00/26] IPUv3 prep for video capture Date: Tue, 19 Aug 2014 10:37:48 -0700 Message-ID: <53F38B6C.4040307@gmail.com> References: <1408369225-21093-1-git-send-email-p.zabel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by gabe.freedesktop.org (Postfix) with ESMTP id DA0BE8994A for ; Tue, 19 Aug 2014 10:38:00 -0700 (PDT) Received: by mail-pa0-f51.google.com with SMTP id ey11so10185238pad.24 for ; Tue, 19 Aug 2014 10:37:57 -0700 (PDT) In-Reply-To: <1408369225-21093-1-git-send-email-p.zabel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel , dri-devel@lists.freedesktop.org Cc: Steve Longerbeam , Russell King , kernel@pengutronix.de List-Id: dri-devel@lists.freedesktop.org On 08/18/2014 06:39 AM, Philipp Zabel wrote: > Hi, > > this series of patches adds IPUv3 core code in preparation for > video capture support and cleans up the CPMEM handling a bit. > > The first version of this series has been sent to the > linux-media@vger.kernel.org list. I'm sending to dri-devel now, > as I'd like to prepare a branch with them for Dave to pull. > > I have moved the ipu-cpmem change to the beginning so that it > can be merged into the staging tree for imx-drm if needed, dropped > a few patches with open questions as well as the channel linking > for now, and changed some patches as indicated in the patch > descriptions. Steve, are you ok with the changes so far? Hi Phillip, yes for the most part. Channel linking will at some point be needed to support no-CPU-intervention image rotation, in some form, but I agree that can be postponed. I did make some changes that relate to patch 5 (Add Camera Sensor Interface unit), I'll comment there. The rest look fine to me. Steve > > > regards > Philipp > > Steve Longerbeam (26): > gpu: ipu-v3: Add ipu-cpmem unit > staging: imx-drm: Convert to new ipu_cpmem API > gpu: ipu-v3: Add functions to set CSI/IC source muxes > gpu: ipu-v3: Rename and add IDMAC channels > gpu: ipu-v3: Add Camera Sensor Interface unit > gpu: ipu-v3: Add Image Converter unit > gpu: ipu-v3: smfc: Move enable/disable to ipu-smfc.c > gpu: ipu-v3: smfc: Convert to per-channel > gpu: ipu-v3: smfc: Add ipu_smfc_set_watermark() > gpu: ipu-v3: Add ipu_mbus_code_to_colorspace() > gpu: ipu-v3: Add rotation mode conversion utilities > gpu: ipu-v3: Add helper function checking if pixfmt is planar > gpu: ipu-v3: Move IDMAC channel names to imx-ipu-v3.h > gpu: ipu-v3: Add ipu_idmac_buffer_is_ready() > gpu: ipu-v3: Add ipu_idmac_clear_buffer() > gpu: ipu-v3: Add __ipu_idmac_reset_current_buffer() > gpu: ipu-v3: Add ipu_stride_to_bytes() > gpu: ipu-v3: Add ipu_idmac_enable_watermark() > gpu: ipu-v3: Add ipu_idmac_lock_enable() > gpu: ipu-cpmem: Add ipu_cpmem_set_block_mode() > gpu: ipu-cpmem: Add ipu_cpmem_set_axi_id() > gpu: ipu-cpmem: Add ipu_cpmem_set_rotation() > gpu: ipu-cpmem: Add second buffer support to ipu_cpmem_set_image() > gpu: ipu-v3: Add more planar formats support > gpu: ipu-cpmem: Add ipu_cpmem_dump() > gpu: ipu-v3: Add ipu_dump() > > drivers/gpu/ipu-v3/Makefile | 3 +- > drivers/gpu/ipu-v3/ipu-common.c | 916 +++++++++++++++++----------------- > drivers/gpu/ipu-v3/ipu-cpmem.c | 764 ++++++++++++++++++++++++++++ > drivers/gpu/ipu-v3/ipu-csi.c | 670 +++++++++++++++++++++++++ > drivers/gpu/ipu-v3/ipu-ic.c | 778 +++++++++++++++++++++++++++++ > drivers/gpu/ipu-v3/ipu-prv.h | 44 +- > drivers/gpu/ipu-v3/ipu-smfc.c | 156 +++++- > drivers/staging/imx-drm/ipuv3-plane.c | 16 +- > include/video/imx-ipu-v3.h | 362 ++++++++------ > 9 files changed, 3037 insertions(+), 672 deletions(-) > create mode 100644 drivers/gpu/ipu-v3/ipu-cpmem.c > create mode 100644 drivers/gpu/ipu-v3/ipu-csi.c > create mode 100644 drivers/gpu/ipu-v3/ipu-ic.c >