From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Cc: Johannes Sixt <j6t@kdbg.org>, Git Mailing List <git@vger.kernel.org>
Subject: [PATCH v2 3/4] run-command: call run_command_v_opt_cd_env() instead of duplicating it
Date: Tue, 19 Aug 2014 21:11:00 +0200 [thread overview]
Message-ID: <53F3A144.4030307@web.de> (raw)
In-Reply-To: <xmqq61hpybs9.fsf@gitster.dls.corp.google.com>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
run-command.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/run-command.c b/run-command.c
index 47ab21b..9196ee0 100644
--- a/run-command.c
+++ b/run-command.c
@@ -577,9 +577,7 @@ static void prepare_run_command_v_opt(struct child_process *cmd,
int run_command_v_opt(const char **argv, int opt)
{
- struct child_process cmd;
- prepare_run_command_v_opt(&cmd, argv, opt);
- return run_command(&cmd);
+ return run_command_v_opt_cd_env(argv, opt, NULL, NULL);
}
int run_command_v_opt_cd_env(const char **argv, int opt, const char *dir, const char *const *env)
--
2.1.0
next prev parent reply other threads:[~2014-08-19 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 22:55 [PATCH] run-command: introduce CHILD_PROCESS_INIT René Scharfe
2014-08-17 7:12 ` Jeff King
2014-08-17 7:25 ` René Scharfe
2014-08-17 7:29 ` Jeff King
2014-08-17 7:46 ` Johannes Sixt
2014-08-17 8:48 ` Jeff King
2014-08-18 16:59 ` Junio C Hamano
2014-08-19 19:09 ` [PATCH v2 1/4] " René Scharfe
2014-08-19 19:10 ` [PATCH v2 2/4] run-command: introduce child_process_init() René Scharfe
2014-08-19 19:11 ` René Scharfe [this message]
2014-08-19 19:11 ` [PATCH v2 4/4] run-command: inline prepare_run_command_v_opt() René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F3A144.4030307@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.