From: Chris Mason <clm@fb.com>
To: Liu Bo <bo.li.liu@oracle.com>, linux-btrfs <linux-btrfs@vger.kernel.org>
Cc: Chris Murphy <lists@colorremedies.com>
Subject: Re: [PATCH] Btrfs: fix crash on endio of reading corrupted block
Date: Tue, 19 Aug 2014 15:49:08 -0400 [thread overview]
Message-ID: <53F3AA34.7030809@fb.com> (raw)
In-Reply-To: <1408462393-3291-1-git-send-email-bo.li.liu@oracle.com>
On 08/19/2014 11:33 AM, Liu Bo wrote:
> The crash is
>
> ------------[ cut here ]------------
> kernel BUG at fs/btrfs/extent_io.c:2124!
> [...]
> Workqueue: btrfs-endio normal_work_helper [btrfs]
> RIP: 0010:[<ffffffffa02d6055>] [<ffffffffa02d6055>] end_bio_extent_readpage+0xb45/0xcd0 [btrfs]
>
> This is in fact a regression.
>
> It is because we forgot to increase @offset properly in reading corrupted block,
> so that the @offset remains, and this leads to checksum errors while reading
> left blocks queued up in the same bio, and then ends up with hiting the above
> BUG_ON.
Thanks Chris and Liu, this is queued.
-chris
next prev parent reply other threads:[~2014-08-19 19:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 15:33 [PATCH] Btrfs: fix crash on endio of reading corrupted block Liu Bo
2014-08-19 19:49 ` Chris Mason [this message]
2014-08-19 21:42 ` Eric Sandeen
2014-08-20 8:20 ` Liu Bo
2014-08-20 8:51 ` [PATCH v2] " Liu Bo
2014-08-22 15:32 ` Eric Sandeen
2014-08-23 3:53 ` Liu Bo
2014-08-23 3:59 ` Liu Bo
2014-08-23 4:00 ` [PATCH v3] " Liu Bo
2014-09-02 20:17 ` Chris Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F3AA34.7030809@fb.com \
--to=clm@fb.com \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lists@colorremedies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.