From: Jens Axboe <axboe@kernel.dk>
To: castor.fu@egocast.org, fio@vger.kernel.org
Cc: Castor Fu <castor@alumni.caltech.edu>, Huamin Chen <hchen@redhat.com>
Subject: Re: [PATCH] Add unlink hook to ioengine API, gluster ioengine
Date: Tue, 19 Aug 2014 15:16:12 -0500 [thread overview]
Message-ID: <53F3B08C.30703@kernel.dk> (raw)
In-Reply-To: <1408465733-3061-1-git-send-email-castor.fu@egocast.org>
On 2014-08-19 11:28, castor.fu@egocast.org wrote:
> From: Castor Fu <castor@alumni.caltech.edu>
>
> fio would just call unlink even with engines that are not using the
> operating systems file namespace... This provides a hook to allow
> overriding that, with a default handler, and implements it for the
> gluster ioengine.
>
> There are others which it'd probably make sense I'm sure.
>
> Huamin Chen looked over my changes to the gluster code earlier...
>> I like this unlink idea, it would be great if you can also make unlink optional (if my coding reading is correct). This looks a great pull request candidate to fio. Please ping Axboe after you are done. He is not actively watching pull requests.
>
>> Please also feel free to augment gluster code and pull me for review if necessary.
>
Thanks, applied. I do monitor pull requests, I setup github to notify me
of them when this last came up. But either is fine, pull request of
emailed patch.
--
Jens Axboe
prev parent reply other threads:[~2014-08-19 20:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 16:28 [PATCH] Add unlink hook to ioengine API, gluster ioengine castor.fu
2014-08-19 20:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F3B08C.30703@kernel.dk \
--to=axboe@kernel.dk \
--cc=castor.fu@egocast.org \
--cc=castor@alumni.caltech.edu \
--cc=fio@vger.kernel.org \
--cc=hchen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.