All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Shi <yang.shi@windriver.com>
To: Bruce Ashfield <bruce.ashfield@windriver.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [V2 PATCH] kernel: Prevent from installing so files into source dir
Date: Tue, 19 Aug 2014 14:21:50 -0700	[thread overview]
Message-ID: <53F3BFEE.70904@windriver.com> (raw)
In-Reply-To: <53F3ABEA.6060602@windriver.com>

On 8/19/2014 12:56 PM, Bruce Ashfield wrote:
> On 14-08-19 02:59 PM, Yang Shi wrote:
>> On 8/19/2014 11:42 AM, Bruce Ashfield wrote:
>>> On 14-08-19 02:39 PM, Yang Shi wrote:
>>>> vdso build could generate so files, avoid installing such so files
>>>> into kernel
>>>> source dir, otherwise the below package QA error might be hit:
>>>>
>>>> ERROR: QA Issue: File '/usr/src/kernel/arch/x86/vdso/vdso64.so' from
>>>> linux-windriver was already stripped, this will prevent future
>>>
>>> We wouldn't want to capture linux-windriver in the commit log .. I 
>>> assume
>>> that this is possible to see with the stock linux-yocto kernel as
>>> well ?
>>
>> I didn't try it with linux-yocto. But, if we use externalsrc, I think
>> linux-yocto should have the same problem.
>
> Shouldn't be too hard to confirm. We want the log to be based on
> oe-core components (as the tests should be), so it is worth a
> quick re-test and a v3 .. sorry for being a pain on this.

Tested on oe-core, updated commit log accordingly. V3 is coming soon.

Yang

>
> Bruce
>
>>
>> Yang
>>
>>>
>>> Bruce
>>>
>>>> debugging! [already-stripped]
>>>>
>>>> Signed-off-by: Yang Shi <yang.shi@windriver.com>
>>>> ---
>>>>   meta/classes/kernel.bbclass | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>>> index 819c302..435b6f0 100644
>>>> --- a/meta/classes/kernel.bbclass
>>>> +++ b/meta/classes/kernel.bbclass
>>>> @@ -253,7 +253,7 @@ kernel_do_install() {
>>>>       # dir. This ensures the original Makefiles are used and not the
>>>>       # redirecting Makefiles in the build directory.
>>>>       #
>>>> -    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name
>>>> "*.so.dbg" -not -path "./Documentation*" -not -path "./source*" -not
>>>> -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>>>> +    find . -depth -not -name "*.cmd" -not -name "*.o" -not -name
>>>> "*.so.dbg" -not -name "*.so" -not -path "./Documentation*" -not -path
>>>> "./source*" -not -path "./.*" -print0 | cpio --null -pdlu $kerneldir
>>>>       cp .config $kerneldir
>>>>       if [ "${S}" != "${B}" ]; then
>>>>           pwd="$PWD"
>>>>
>>>
>>>
>>>
>>
>
>
>



      reply	other threads:[~2014-08-19 21:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-19 18:39 [V2 PATCH] kernel: Prevent from installing so files into source dir Yang Shi
2014-08-19 18:42 ` Bruce Ashfield
2014-08-19 18:59   ` Yang Shi
2014-08-19 19:56     ` Bruce Ashfield
2014-08-19 21:21       ` Yang Shi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F3BFEE.70904@windriver.com \
    --to=yang.shi@windriver.com \
    --cc=bruce.ashfield@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.