From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: tegra: initial support for apalis t30
Date: Tue, 19 Aug 2014 15:42:16 -0600 [thread overview]
Message-ID: <53F3C4B8.40805@wwwdotorg.org> (raw)
In-Reply-To: <fbc7f71aac359e0c9220fc01db7a7a597afb97c5.1408403674.git.marcel@ziswiler.com>
On 08/18/2014 05:22 PM, Marcel Ziswiler wrote:
> This patch adds board support for the Toradex Apalis T30 a computer on
> module which can be used on different carrier boards.
>
> For the sake of ease of use we do not distinguish between different
> carrier boards for now as the base module features are deemed
> sufficient enough for regular booting.
>
> The following functionality is working so far:
> - eMMC boot and environment storage
> - MMC/SD cards (both 8-bit as well as 4-bit slot)
> - Network (via external ASIX USB)
> - USB client/host (dual role port as client, other two ports as host)
At a quick glance this looks OK,
Acked-by: Stephen Warren <swarren@nvidia.com>
One very minor nit:
> diff --git a/arch/arm/dts/tegra30-apalis.dts b/arch/arm/dts/tegra30-apalis.dts
> + /* GEN1_I2C: I2C1_SDA/SCL on MXM3 pin 209/211 (e.g. RTC on carrier
> + board) */
That comment style is odd. It should be:
/*
* Text here
* More here
*/
next prev parent reply other threads:[~2014-08-19 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <74725faaf1af8f3d1791693634e69f5ba1eb9f38.1408403674.git.marcel@ziswiler.com>
2014-08-18 23:22 ` [U-Boot] [PATCH] arm: tegra: initial support for apalis t30 Marcel Ziswiler
2014-08-19 21:42 ` Stephen Warren [this message]
2014-08-20 7:35 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F3C4B8.40805@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.