From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [Patch v3 1/1] Add Odroid-XU (Exynos5410) Date: Tue, 19 Aug 2014 16:46:10 -0500 Message-ID: <53F3C5A2.40902@linaro.org> References: <1407985978-13997-1-git-send-email-suriyan.r@gmail.com> <53F24EFA.8020409@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Suriyan Ramasami Cc: keir@xen.org, Ian Campbell , ian.jackson@eu.citrix.com, Tim Deegan , "xen-devel@lists.xen.org" , Jan Beulich List-Id: xen-devel@lists.xenproject.org Hello, On 18/08/14 17:21, Suriyan Ramasami wrote: >> I would rename S5P_PA_SYSRAM and EXYNOS5_* to something specific to exynos >> 5250. It would make clear that new platform should use the device tree to >> get information. >> > I shall rename S5P_PA_SYSRAM to EXYNOS5250_PA_SYSRAM. > Do you also want me to rename the other ones, like EXYNOS5_MCT_* > defines in the exynos5.h header file as well? You are using EXYNOS5_MCT_* on both board so I don't think you have to rename it. The best things would be using the device tree rather than an hardcoded value. But it's not the scope of this patch :). > If so, do you want me to get rid of exynos5.h and dump all the defines > in exynos5.c ? It would be nice but not necessary for this patch. Regards, -- Julien Grall