From: Bart Van Assche <bvanassche@acm.org>
To: Kashyap.Desai@avagotech.com, linux-scsi@vger.kernel.org
Cc: aacraid@adaptec.com, Elliott@hp.com, jbottomley@parallels.com,
hch@infradead.org
Subject: Re: [PATCH] scsi.mq:Added enable_cmd_list flags in hostt to reduce lock contention
Date: Wed, 20 Aug 2014 12:48:24 +0200 [thread overview]
Message-ID: <53F47CF8.3080708@acm.org> (raw)
In-Reply-To: <201408191819.s7JIIx12019025@palmhbs0.lsi.com>
On 08/19/14 20:17, Kashyap.Desai@avagotech.com wrote:
> + if (shost->hostt->enable_cmd_list) {
This code is in the hot path which means that caching "enable_cmd_list"
in struct Scsi_Host (as is done for many other SCSI host parameters)
probably will (slightly) improve performance further. Otherwise this
patch looks fine to me.
Bart.
next prev parent reply other threads:[~2014-08-20 10:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 18:17 [PATCH] scsi.mq:Added enable_cmd_list flags in hostt to reduce lock contention Kashyap.Desai
2014-08-20 10:48 ` Bart Van Assche [this message]
2014-08-20 12:38 ` Kashyap Desai
2014-08-20 12:41 ` Christoph Hellwig
2014-08-20 12:46 ` Kashyap Desai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F47CF8.3080708@acm.org \
--to=bvanassche@acm.org \
--cc=Elliott@hp.com \
--cc=Kashyap.Desai@avagotech.com \
--cc=aacraid@adaptec.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.