Re: [PATCH] KVM: x86: Replace X86_FEATURE_NX offset with the definition

[Paolo Bonzini <pbonzini@redhat.com>]

Il 20/08/2014 15:38, Nadav Amit ha scritto:
> Replace reference to X86_FEATURE_NX using bit shift with the defined
> X86_FEATURE_NX.
> 
> Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
> ---
>  arch/x86/kvm/cpuid.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> index 38a0afe..f4bad87 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -112,8 +112,8 @@ static void cpuid_fix_nx_cap(struct kvm_vcpu *vcpu)
>  			break;
>  		}
>  	}
> -	if (entry && (entry->edx & (1 << 20)) && !is_efer_nx()) {
> -		entry->edx &= ~(1 << 20);
> +	if (entry && (entry->edx & bit(X86_FEATURE_NX)) && !is_efer_nx()) {
> +		entry->edx &= ~bit(X86_FEATURE_NX);
>  		printk(KERN_INFO "kvm: guest NX capability removed\n");
>  	}
>  }
> 

Applying, thanks.

Paolo