From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51754)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Joel.Schopp@amd.com>) id 1XKBMT-00027J-Re
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:16:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Joel.Schopp@amd.com>) id 1XKBMM-0002IW-CO
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:15:57 -0400
Received: from mail-bn1blp0188.outbound.protection.outlook.com
	([207.46.163.188]:52016
	helo=na01-bn1-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Joel.Schopp@amd.com>) id 1XKBMM-0002IN-7Y
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:15:50 -0400
Message-ID: <53F4F336.1040101@amd.com>
Date: Wed, 20 Aug 2014 14:12:54 -0500
From: Joel Schopp <joel.schopp@amd.com>
MIME-Version: 1.0
References: <1407594349-9291-1-git-send-email-eric.auger@linaro.org>
	<1407594349-9291-7-git-send-email-eric.auger@linaro.org>
In-Reply-To: <1407594349-9291-7-git-send-email-eric.auger@linaro.org>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 06/10] hw/vfio: create common module
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Auger <eric.auger@linaro.org>, eric.auger@st.com, christoffer.dall@linaro.org, qemu-devel@nongnu.org, kim.phillips@freescale.com, a.rigo@virtualopensystems.com
Cc: peter.maydell@linaro.org, patches@linaro.org, Kim Phillips <kim.phillips@linaro.org>, will.deacon@arm.com, agraf@suse.de, stuart.yoder@freescale.com, Bharat.Bhushan@freescale.com, alex.williamson@redhat.com, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu


> +int vfio_get_device(VFIOGroup *group, const char *name,
> +                       VFIODevice *vbasedev)
> +{
> +    struct vfio_device_info dev_info = { .argsz = sizeof(dev_info) };
> +    struct vfio_region_info reg_info = { .argsz = sizeof(reg_info) };
> +    struct vfio_irq_info irq_info = { .argsz = sizeof(irq_info) };
> +    int ret;
> +
> +    ret = ioctl(group->fd, VFIO_GROUP_GET_DEVICE_FD, name);
> +    if (ret < 0) {
Should be:
if(ret) {
instead of:
if (ret < 0) {

The ioctl can, and sometimes does, return positive values in case of
errors.  This should also be fixed in vfio_container_do_ioctl()