From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBTH-0006vx-KO for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:23:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKBTC-0004Wn-M9 for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:22:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBTC-0004W2-E1 for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:22:54 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KJMrll028503 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Aug 2014 15:22:53 -0400 Message-ID: <53F4F58C.1050205@redhat.com> Date: Wed, 20 Aug 2014 13:22:52 -0600 From: Eric Blake MIME-Version: 1.0 References: <1408557576-14574-1-git-send-email-mreitz@redhat.com> <1408557576-14574-4-git-send-email-mreitz@redhat.com> In-Reply-To: <1408557576-14574-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sLNWATX79IqBOEIQ1Ecr3bfF9fsqD9WO8" Subject: Re: [Qemu-devel] [PATCH 3/4] qcow2: Add overlap-check.template option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sLNWATX79IqBOEIQ1Ecr3bfF9fsqD9WO8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/20/2014 11:59 AM, Max Reitz wrote: > Being able to set the overlap-check option to a string and then refine > it via the overlap-check.* options is a nice idea for the command line > but does not work so well for non-flattened dicts. In that case, one ca= n > only specify either but not both, so add a field to overlap-check.* > which does the same as directly specifying overlap-check but can be use= d > in conjunction with the other fields in non-flattened dicts. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 24 ++++++++++++++++++++++-- > block/qcow2.h | 1 + > 2 files changed, 23 insertions(+), 2 deletions(-) >=20 > diff --git a/block/qcow2.c b/block/qcow2.c > index c64d611..c6099b5 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -403,6 +403,12 @@ static QemuOptsList qcow2_runtime_opts =3D { > "templates (none, constant, cached, all)", > }, > { > + .name =3D QCOW2_OPT_OVERLAP_TEMPLATE, > + .type =3D QEMU_OPT_STRING, > + .help =3D "Selects which overlap checks to perform from a = range of " > + "templates (none, constant, cached, all)", > + }, > + { Okay, I see where this is headed. The QMP will allow either 'overlap-check':'all' (resolve all defaults according to a template name), or 'overlap-check':{'template':'all','inactive-l1':'none'} (that is, a struct, where the struct also sets a default but also provides per-item overrides). It took me a couple of reads of this in tandem with 4/4, but it looks correct. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sLNWATX79IqBOEIQ1Ecr3bfF9fsqD9WO8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT9PWMAAoJEKeha0olJ0NqqlkH/iVXcN9jj+kCj75o5Va/dk8M +UZf1QjNxiSbhgFXKVuVT0MeubCu06SnfgpxhuFh4+gYobnuX8VpT8m2WeTwWXbB jB61JCV4+B6N6BG63rSWff5Xr2i6a1J5m6qRuqgvZgBRDi6PRLv2dZdYRcJuPP/B KXi4zbExxg4LT0TfJ8av3VsIOqFRxoK/qfz3c7XplyFvVxioRay2VKhDFwkkzJCw V8/2gfMVI4iz+7HQreAkSVbPJy/9VqDyopPZYtUMZELE+uc93FyAK7BRcoOIAar/ AQltKD6645yXi+WEw3obeQcbLfFSjwyewG5g1ShFOWqz0xRB/aZlLEKJlczk5tE= =SQCL -----END PGP SIGNATURE----- --sLNWATX79IqBOEIQ1Ecr3bfF9fsqD9WO8--