Re: [Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]

On 08/20/2014 01:38 PM, Max Reitz wrote:

>>> +# Structure of flags for each metadata structure. Setting a field to
>>> 'true'
>>> +# makes qemu guard that structure against unintended overwriting.
>>> The default
>>> +# value is chosen according to the template given.
>>> +#
>>> +# @template: Specifies a template mode which can be adjusted using
>>> the other
>>> +#            flags, defaults to 'cached'
>>> +#
>> Might be worth mentioning the other fields by name, but that's minor.
> 
> Well, there were so many and it would've just been "X: Prevent
> unintended writes to X".

Bike-shedding ahead: maybe avoid the duplication by listing things in a
list, such as:

# @template: #optional Specify the template that controls the defaults
for all other fields (defaults to 'cached')

# @main-header, @active-l1, @active-l2, ...: #optional Specify a
specific override of whether to prevent unintended writes to that data
section (defaults determined by @template)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]