From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752585AbaHUCGd (ORCPT ); Wed, 20 Aug 2014 22:06:33 -0400 Received: from mail-qc0-f179.google.com ([209.85.216.179]:58416 "EHLO mail-qc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbaHUCGc (ORCPT ); Wed, 20 Aug 2014 22:06:32 -0400 Message-ID: <53F55423.7030902@gmail.com> Date: Wed, 20 Aug 2014 22:06:27 -0400 From: Vlad Yasevich User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Zhu Yanjun , dborkman@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, tuexen@fh-muenster.de, khandelwal.deepak.1987@gmail.com, Yue.Tao@windriver.com, alexandre.dietsch@windriver.com, davem@davemloft.net CC: Zhu Yanjun Subject: Re: [PATCH 1/1] sctp: not send SCTP_PEER_ADDR_CHANGE notifications with failed probe References: <1408527103-22772-1-git-send-email-Yanjun.Zhu@windriver.com> <1408527103-22772-2-git-send-email-Yanjun.Zhu@windriver.com> In-Reply-To: <1408527103-22772-2-git-send-email-Yanjun.Zhu@windriver.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/20/2014 05:31 AM, Zhu Yanjun wrote: > Since the transport has always been in state SCTP_UNCONFIRMED, it > therefore wasn't active before and hasn't been used before, and it > always has been, so it is unnecessary to bug the user with a > notification. > > Reported-by: Deepak Khandelwal > Suggested-by: Vlad Yasevich > Suggested-by: Michael Tuexen > Suggested-by: Daniel Borkmann > Signed-off-by: Zhu Yanjun Acked-by: Vlad Yasevich Thanks -vlad > --- > net/sctp/associola.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/sctp/associola.c b/net/sctp/associola.c > index 9de23a2..2e23f6b 100644 > --- a/net/sctp/associola.c > +++ b/net/sctp/associola.c > @@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc, > else { > dst_release(transport->dst); > transport->dst = NULL; > + ulp_notify = false; > } > > spc_state = SCTP_ADDR_UNREACHABLE; >